Virtual disk: add different migration test cases

Automate:
RHEL-175001 - [Migration] Migrate vm with disk type= block - logical volume based on iscsi
VIRT-19098 - [Migration] Migrate with nbd disk defined in xml

Signed-off-by: Meina Li <[email protected]>

Author: meinaLi

libvirt/tests/cfg/migration/migration_with_disk/migration_with_different_disks.cfg

@@ -0,0 +1,50 @@
+- migration.migration_with_disk.migration_with_different_disks:
+    type = migration_with_different_disks
+    start_vm = "no"
+    migration_setup = "yes"
+    storage_type = "nfs"
+    setup_local_nfs = "yes"
+    disk_type = "file"
+    disk_source_protocol = "netfs"
+    mnt_path_name = ${nfs_mount_dir}
+    # Console output can only be monitored via virsh console output
+    only_pty = True
+    take_regular_screendumps = no
+    # Extra options to pass after <domain> <desturi>
+    virsh_migrate_extra = ""
+    ssh_timeout = 60
+    virsh_migrate_connect_uri = "qemu:///system"
+    virsh_migrate_dest_state = "running"
+    virsh_migrate_src_state = "shut off"
+    server_ip = "${migrate_dest_host}"
+    server_user = "root"
+    server_pwd = "${migrate_dest_pwd}"
+    client_ip = "${migrate_source_host}"
+    client_pwd = "${migrate_source_pwd}"
+    migrate_desturi_port = "22"
+    migrate_desturi_type = "ssh"
+    virsh_migrate_desturi = "qemu+ssh://${migrate_dest_host}/system"
+    check_disk_after_mig = "yes"
+    simple_disk_check_after_mig = "yes"
+    no ppc64le
+    variants test_scenario:
+        - block_disk:
+            disk_type = "block"
+            check_disk_kname_after_mig = "sda"
+            vg_name = "vg0"
+            lv_name = "lv0"
+            lv_size = "200M"
+            target_emulate_image = "emulated-iscsi2"
+            disk_dict = {"type_name": "block", "device": "disk", "driver": {"name": "qemu", "type": "raw"}, "target": {"dev": "${check_disk_kname_after_mig}", "bus": "scsi"}}
+        - nbd_disk:
+            disk_type = "nbd"
+            enable_tls = "no"
+            check_disk_kname_after_mig = "vdb"
+            nbd_server_port = "10809"
+            shared_num = "2"
+            disk_dict = {"type_name": "network", "device": "disk", "driver": {"name": "qemu", "type": "raw"}, "target": {"dev": "${check_disk_kname_after_mig}", "bus": "virtio"}}
+    variants:
+        - with_precopy:
+            virsh_migrate_options = "--live --p2p --persistent --verbose"
+        - with_postcopy:
+            virsh_migrate_options = "--live --p2p --persistent --verbose --postcopy --timeout 10 --timeout-postcopy"

libvirt/tests/src/migration/migration_with_disk/migration_with_different_disks.py

@@ -0,0 +1,109 @@
+import ast
+
+from avocado.utils import process
+
+from virttest import remote
+from virttest import utils_disk
+from virttest import utils_test
+from virttest import utils_iptables
+
+from virttest.utils_libvirt import libvirt_disk
+from virttest.utils_test import libvirt
+
+from provider.migration import base_steps
+from provider.virtual_disk import disk_base
+
+
+def setup_block_remote(params, test):
+    """
+    Setup iSCSI target on remote host.
+
+    :param params: test parameters
+    :param test: test object
+    """
+    test.log.info("Setting up iSCSI target on remote host.")
+    client_ip = params.get("client_ip")
+    vg_name = params.get("vg_name", "vg0")
+    lv_name = params.get("lv_name", "lv0")
+    lv_size = params.get("lv_size", "200M")
+    target_emulate_image = params.get("target_emulate_image", "emulated-iscsi2")
+    block_dev = utils_test.RemoteDiskManager(params)
+    iscsi_target, _ = libvirt.setup_or_cleanup_iscsi(is_setup=True,
+                                                     is_login=False,
+                                                     emulated_image=target_emulate_image,
+                                                     portal_ip=client_ip)
+
+    remote_device = block_dev.iscsi_login_setup(client_ip, iscsi_target)
+    clear_dm_dev = (
+        f"dmsetup ls --noheadings | awk '/^{vg_name}-/ {{print $1}}' "
+        f"| xargs -r dmsetup remove --force; rm -rf /dev/{vg_name}"
+    )
+    remote.run_remote_cmd(clear_dm_dev, params, ignore_status=True)
+    block_dev.create_vg(vg_name, remote_device)
+    block_dev.create_image("lvm",
+                           size=lv_size,
+                           vgname=vg_name,
+                           lvname=lv_name,
+                           sparse=False,
+                           timeout=60)
+
+
+def run(test, params, env):
+    """
+    Test migration with different disk types (iSCSI LV and NBD).
+    """
+    def setup_test():
+        """
+        Setup steps for migration with different disk types.
+        """
+        test.log.info("Setting up %s disk test environment for guest.", disk_type)
+        migration_obj.setup_connection()
+        disk_obj.new_image_path = disk_obj.add_vm_disk(disk_type, disk_dict)
+        if not vm.is_alive():
+            vm.start()
+
+        vm_session = vm.wait_for_login()
+        source_disk_name, _ = libvirt_disk.get_non_root_disk_name(vm_session)
+        utils_disk.dd_data_to_vm_disk(vm_session, source_disk_name)
+        vm_session.close()
+
+        if disk_type == "block":
+            setup_block_remote(params, test)
+
+        if disk_type == "nbd":
+            firewall_cmd.add_port(nbd_server_port, "tcp", permanent=True)
+
+    def cleanup_test():
+        """
+        Cleanup steps for migration with different disk types.
+        """
+        test.log.info("Cleanup steps for migration with different disk types.")
+        migration_obj.cleanup_connection()
+        disk_obj.cleanup_disk_preparation(disk_type)
+        if disk_type == "block":
+            remote.run_remote_cmd("iscsiadm -m session -u", params, ignore_status=True)
+            libvirt.setup_or_cleanup_iscsi(is_setup=False,
+                                           emulated_image=target_emulate_image,
+                                           portal_ip=client_ip)
+        if disk_type == "nbd":
+            firewall_cmd.remove_port(nbd_server_port, "tcp", permanent=True)
+
+    vm_name = params.get("migrate_main_vm")
+    vm = env.get_vm(vm_name)
+    disk_type = params.get("disk_type")
+    client_ip = params.get("client_ip")
+    target_emulate_image = params.get("target_emulate_image", "emulated-iscsi2")
+    disk_dict = ast.literal_eval(params.get("disk_dict", "{}"))
+    nbd_server_port = params.get("nbd_server_port", "10809")
+
+    base_steps.sync_cpu_for_mig(params)
+    migration_obj = base_steps.MigrationBase(test, vm, params)
+    disk_obj = disk_base.DiskBase(test, vm, params)
+    firewall_cmd = utils_iptables.Firewall_cmd()
+
+    try:
+        setup_test()
+        migration_obj.run_migration()
+        migration_obj.verify_default()
+    finally:
+        cleanup_test()

provider/virtual_disk/disk_base.py

@@ -200,12 +200,13 @@ def prepare_disk_obj(self, disk_type, disk_dict, new_image_path='', **kwargs):
             device_format = self.params.get("device_format", "qcow2")
             export_name = self.params.get("export_name", "new")
             tls_enabled = "yes" == self.params.get("enable_tls", "yes")
+            shared_num = self.params.get("shared_num")
             image_size = kwargs.get("size",
                                     self.params.get("image_size", "500M"))
 
             self.disk_backend = NbdExport(
                 image_path, image_format=device_format, port=nbd_server_port,
-                image_size=image_size, export_name=export_name, tls=tls_enabled)
+                image_size=image_size, export_name=export_name, tls=tls_enabled, shared_num=shared_num)
             self.disk_backend.start_nbd_server()
             utils_misc.wait_for(
                 lambda: process.system('netstat -nlp | grep %s ' % nbd_server_port, ignore_status=True, shell=True) == 0, 10)