From 02fadd28da12ebb2cc5e5e2b98e1538d2d06617b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 15:25:24 +0300 Subject: [PATCH 01/15] ci(build-test-tidy): introduce success condition jobs This reverts commit 054831fff8dfa825ce45a4111fcea88aff5bc287. --- .github/workflows/build-test-tidy-pr.yaml | 28 +++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index df2eff132eb05..89433c3ccb2b8 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -58,6 +58,20 @@ jobs: secrets: codecov-token: ${{ secrets.CODECOV_TOKEN }} + build-test-pr: + needs: + - build-and-test-differential + - build-and-test-differential-cuda + if: ${{ always() }} + runs-on: ubuntu-latest + steps: + - name: Check build-and-test success + if: ${{ needs.build-and-test-differential.result == 'success' && (needs.build-and-test-differential-cuda.result == 'success' || needs.build-and-test-differential-cuda.result == 'skipped') }} + run: echo "build-test-pr succeeded." + - name: Fail if conditions not met + if: ${{ !(needs.build-and-test-differential.result == 'success' && (needs.build-and-test-differential-cuda.result == 'success' || needs.build-and-test-differential-cuda.result == 'skipped')) }} + run: exit 1 + clang-tidy-differential: needs: - check-if-cuda-job-is-needed @@ -74,3 +88,17 @@ jobs: with: container: ghcr.io/autowarefoundation/autoware:universe-devel container-suffix: -cuda + + clang-tidy-pr: + needs: + - clang-tidy-differential + - clang-tidy-differential-cuda + if: ${{ always() }} + runs-on: ubuntu-latest + steps: + - name: Check clang-tidy success + if: ${{ needs.clang-tidy-differential.result == 'success' || needs.clang-tidy-differential-cuda.result == 'success' }} + run: echo "clang-tidy-pr succeeded." + - name: Fail if conditions not met + if: ${{ !(needs.clang-tidy-differential.result == 'success' || needs.clang-tidy-differential-cuda.result == 'success') }} + run: exit 1 From dd65c96deca4d96735593d0a61b47d3f5c5d0adb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 17:16:48 +0300 Subject: [PATCH 02/15] ex MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../actions/evaluate-job-result/action.yaml | 46 +++++++++++++++++++ .github/workflows/build-test-tidy-pr.yaml | 35 +++++++++++--- 2 files changed, 75 insertions(+), 6 deletions(-) create mode 100644 .github/actions/evaluate-job-result/action.yaml diff --git a/.github/actions/evaluate-job-result/action.yaml b/.github/actions/evaluate-job-result/action.yaml new file mode 100644 index 0000000000000..60466fbc1222a --- /dev/null +++ b/.github/actions/evaluate-job-result/action.yaml @@ -0,0 +1,46 @@ +name: Evaluate Job Result +description: Evaluates the result of a job and updates the summary. +inputs: + job_result: + description: Result of the job to evaluate (e.g., success, failure, skipped) + required: true + type: string + job_name: + description: Name of the job to evaluate + required: true + type: string + expected_results: + description: Comma-separated list of acceptable results (e.g., success,skipped) + required: true + type: string +outputs: + failed: + description: Indicates if the job failed + type: boolean + value: ${{ steps.evaluate.outputs.failed }} + +runs: + using: composite + steps: + - name: Evaluate Job Result + id: evaluate + shell: bash + run: | + JOB_RESULT="${{ inputs.job_result }}" + IFS=',' read -ra EXPECTED <<< "${{ inputs.expected_results }}" + SUMMARY_LINE="" + FAILED=false + + for RESULT in "${EXPECTED[@]}"; do + if [[ "$JOB_RESULT" == "$RESULT" ]]; then + SUMMARY_LINE="- ${{ inputs.job_name }}: Success ✅" + echo "$SUMMARY_LINE" >> "$GITHUB_STEP_SUMMARY" + echo "failed=false" >> "$GITHUB_OUTPUT" + exit 0 + fi + done + + # If no expected result matched + echo "::error::${{ inputs.job_name }} failed. ❌" + SUMMARY_LINE="- ${{ inputs.job_name }}: Failed ❌" >> "$GITHUB_STEP_SUMMARY" + echo "failed=true" >> "$GITHUB_OUTPUT" diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 89433c3ccb2b8..55c0e409d42dc 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -65,12 +65,35 @@ jobs: if: ${{ always() }} runs-on: ubuntu-latest steps: - - name: Check build-and-test success - if: ${{ needs.build-and-test-differential.result == 'success' && (needs.build-and-test-differential-cuda.result == 'success' || needs.build-and-test-differential-cuda.result == 'skipped') }} - run: echo "build-test-pr succeeded." - - name: Fail if conditions not met - if: ${{ !(needs.build-and-test-differential.result == 'success' && (needs.build-and-test-differential-cuda.result == 'success' || needs.build-and-test-differential-cuda.result == 'skipped')) }} - run: exit 1 + - name: Initialize Summary + run: echo "### Build Test PR Results" > $GITHUB_STEP_SUMMARY + shell: bash + + - name: Evaluate build-and-test-differential + id: eval_diff + uses: ./.github/actions/evaluate-job-result + with: + job_result: ${{ needs.build-and-test-differential.result }} + job_name: build-and-test-differential + expected_results: success + + - name: Evaluate build-and-test-differential-cuda + id: eval_cuda + uses: ./.github/actions/evaluate-job-result + with: + job_result: ${{ needs.build-and-test-differential-cuda.result }} + job_name: build-and-test-differential-cuda + expected_results: success,skipped + + - name: Final Status + run: | + if [[ "${{ steps.eval_diff.outputs.failed }}" == "true" || "${{ steps.eval_cuda.outputs.failed }}" == "true" ]]; then + echo "Some checks failed. ❌" + exit 1 + else + echo "::notice::All checks passed successfully! ✅" + fi + shell: bash clang-tidy-differential: needs: From 1b9a264f44f61e738dd9c9c4fb219a5fa044619d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 17:34:58 +0300 Subject: [PATCH 03/15] add checkout for local action MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../actions/evaluate-job-result/action.yaml | 2 +- .github/workflows/build-test-tidy-pr.yaml | 32 +++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/.github/actions/evaluate-job-result/action.yaml b/.github/actions/evaluate-job-result/action.yaml index 60466fbc1222a..eb952602aff53 100644 --- a/.github/actions/evaluate-job-result/action.yaml +++ b/.github/actions/evaluate-job-result/action.yaml @@ -24,7 +24,6 @@ runs: steps: - name: Evaluate Job Result id: evaluate - shell: bash run: | JOB_RESULT="${{ inputs.job_result }}" IFS=',' read -ra EXPECTED <<< "${{ inputs.expected_results }}" @@ -44,3 +43,4 @@ runs: echo "::error::${{ inputs.job_name }} failed. ❌" SUMMARY_LINE="- ${{ inputs.job_name }}: Failed ❌" >> "$GITHUB_STEP_SUMMARY" echo "failed=true" >> "$GITHUB_OUTPUT" + shell: bash diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 55c0e409d42dc..c3b2dc9975661 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -18,6 +18,36 @@ jobs: with: label: run:build-and-test-differential + require-label-test: + needs: + - require-label + if: ${{ always() }} + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + + - name: Initialize Summary + run: echo "### Build Test PR Results" > $GITHUB_STEP_SUMMARY + shell: bash + + - name: Evaluate build-and-test-differential + id: eval_diff + uses: ./.github/actions/evaluate-job-result + with: + job_result: ${{ needs.build-and-test-differential.result }} + job_name: require-label + expected_results: success + + - name: Final Status + run: | + if [[ "${{ steps.eval_diff.outputs.failed }}" == "true" || "${{ steps.eval_cuda.outputs.failed }}" == "true" ]]; then + echo "Some checks failed. ❌" + exit 1 + else + echo "::notice::All checks passed successfully! ✅" + fi + shell: bash + check-if-cuda-job-is-needed: needs: require-label runs-on: ubuntu-latest @@ -65,6 +95,8 @@ jobs: if: ${{ always() }} runs-on: ubuntu-latest steps: + - uses: actions/checkout@v4 + - name: Initialize Summary run: echo "### Build Test PR Results" > $GITHUB_STEP_SUMMARY shell: bash From 0489dca073209d4da623f51cc8274c9f62e8f6d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 17:36:33 +0300 Subject: [PATCH 04/15] remove type from output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/actions/evaluate-job-result/action.yaml | 1 - .github/workflows/build-test-tidy-pr.yaml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/actions/evaluate-job-result/action.yaml b/.github/actions/evaluate-job-result/action.yaml index eb952602aff53..3439ca93b8b4f 100644 --- a/.github/actions/evaluate-job-result/action.yaml +++ b/.github/actions/evaluate-job-result/action.yaml @@ -16,7 +16,6 @@ inputs: outputs: failed: description: Indicates if the job failed - type: boolean value: ${{ steps.evaluate.outputs.failed }} runs: diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index c3b2dc9975661..fecd5dddcc557 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -34,7 +34,7 @@ jobs: id: eval_diff uses: ./.github/actions/evaluate-job-result with: - job_result: ${{ needs.build-and-test-differential.result }} + job_result: ${{ needs.require-label.result }} job_name: require-label expected_results: success From 609b57c6d609293f3fc0ae21c8d1625a1484d103 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 18:05:49 +0300 Subject: [PATCH 05/15] add summary to clang-tidy too MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../actions/evaluate-job-result/action.yaml | 6 +-- .github/workflows/build-test-tidy-pr.yaml | 50 +++++++------------ 2 files changed, 20 insertions(+), 36 deletions(-) diff --git a/.github/actions/evaluate-job-result/action.yaml b/.github/actions/evaluate-job-result/action.yaml index 3439ca93b8b4f..c76722df6624d 100644 --- a/.github/actions/evaluate-job-result/action.yaml +++ b/.github/actions/evaluate-job-result/action.yaml @@ -26,13 +26,11 @@ runs: run: | JOB_RESULT="${{ inputs.job_result }}" IFS=',' read -ra EXPECTED <<< "${{ inputs.expected_results }}" - SUMMARY_LINE="" FAILED=false for RESULT in "${EXPECTED[@]}"; do if [[ "$JOB_RESULT" == "$RESULT" ]]; then - SUMMARY_LINE="- ${{ inputs.job_name }}: Success ✅" - echo "$SUMMARY_LINE" >> "$GITHUB_STEP_SUMMARY" + echo "- ${{ inputs.job_name }}: Success ✅" >> "$GITHUB_STEP_SUMMARY" echo "failed=false" >> "$GITHUB_OUTPUT" exit 0 fi @@ -40,6 +38,6 @@ runs: # If no expected result matched echo "::error::${{ inputs.job_name }} failed. ❌" - SUMMARY_LINE="- ${{ inputs.job_name }}: Failed ❌" >> "$GITHUB_STEP_SUMMARY" + "- ${{ inputs.job_name }}: Failed ❌" >> "$GITHUB_STEP_SUMMARY" echo "failed=true" >> "$GITHUB_OUTPUT" shell: bash diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index fecd5dddcc557..4e1ba210d0d46 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -18,36 +18,6 @@ jobs: with: label: run:build-and-test-differential - require-label-test: - needs: - - require-label - if: ${{ always() }} - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - - name: Initialize Summary - run: echo "### Build Test PR Results" > $GITHUB_STEP_SUMMARY - shell: bash - - - name: Evaluate build-and-test-differential - id: eval_diff - uses: ./.github/actions/evaluate-job-result - with: - job_result: ${{ needs.require-label.result }} - job_name: require-label - expected_results: success - - - name: Final Status - run: | - if [[ "${{ steps.eval_diff.outputs.failed }}" == "true" || "${{ steps.eval_cuda.outputs.failed }}" == "true" ]]; then - echo "Some checks failed. ❌" - exit 1 - else - echo "::notice::All checks passed successfully! ✅" - fi - shell: bash - check-if-cuda-job-is-needed: needs: require-label runs-on: ubuntu-latest @@ -151,9 +121,25 @@ jobs: if: ${{ always() }} runs-on: ubuntu-latest steps: + - name: Initialize Summary + run: echo "### Clang Tidy PR Results" > $GITHUB_STEP_SUMMARY + shell: bash + - name: Check clang-tidy success if: ${{ needs.clang-tidy-differential.result == 'success' || needs.clang-tidy-differential-cuda.result == 'success' }} - run: echo "clang-tidy-pr succeeded." + run: | + echo "All checks passed successfully! ✅" + echo "All checks passed successfully! ✅" >> $GITHUB_STEP_SUMMARY + - name: Fail if conditions not met if: ${{ !(needs.clang-tidy-differential.result == 'success' || needs.clang-tidy-differential-cuda.result == 'success') }} - run: exit 1 + run: | + echo "::error::❌ Either one of the following should have succeeded:" + echo "::error::clang-tidy-differential: ${{ needs.clang-tidy-differential.result }}" + echo "::error::clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" + + echo "❌ Either one of the following should have succeeded:" >> $GITHUB_STEP_SUMMARY + echo "clang-tidy-differential: ${{ needs.clang-tidy-differential.result }}" >> $GITHUB_STEP_SUMMARY + echo "clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" >> $GITHUB_STEP_SUMMARY + + exit 1 From a646a00be53b5eafb54f0062a299f55d9470f923 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 24 Dec 2024 15:08:27 +0000 Subject: [PATCH 06/15] style(pre-commit): autofix --- .github/workflows/build-test-tidy-pr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 4e1ba210d0d46..9d8446a7f7aaf 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -137,7 +137,7 @@ jobs: echo "::error::❌ Either one of the following should have succeeded:" echo "::error::clang-tidy-differential: ${{ needs.clang-tidy-differential.result }}" echo "::error::clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" - + echo "❌ Either one of the following should have succeeded:" >> $GITHUB_STEP_SUMMARY echo "clang-tidy-differential: ${{ needs.clang-tidy-differential.result }}" >> $GITHUB_STEP_SUMMARY echo "clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" >> $GITHUB_STEP_SUMMARY From 4261c365be2f615d8ced8dc9202e4d21fbc9b1c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 18:27:41 +0300 Subject: [PATCH 07/15] add bullet points MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/workflows/build-test-tidy-pr.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 9d8446a7f7aaf..7fdc8dcb85b47 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -139,7 +139,7 @@ jobs: echo "::error::clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" echo "❌ Either one of the following should have succeeded:" >> $GITHUB_STEP_SUMMARY - echo "clang-tidy-differential: ${{ needs.clang-tidy-differential.result }}" >> $GITHUB_STEP_SUMMARY - echo "clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" >> $GITHUB_STEP_SUMMARY + echo "- clang-tidy-differential: ${{ needs.clang-tidy-differential.result }}" >> $GITHUB_STEP_SUMMARY + echo "- clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" >> $GITHUB_STEP_SUMMARY exit 1 From b885b4ed8c25cf43b5af1643eb83a40c3a095508 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 23 Dec 2024 00:29:22 +0300 Subject: [PATCH 08/15] normal package - bad change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../include/mission_details_display.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp index c3db6a2fec2ef..064e2021e2286 100644 --- a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp +++ b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp @@ -28,7 +28,7 @@ #include #include -#include +#include #include #include From 22499a13e151a5144930ea3f7830108316dc384d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 18:45:07 +0300 Subject: [PATCH 09/15] improve output text MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/actions/evaluate-job-result/action.yaml | 4 ++-- .github/workflows/build-test-tidy-pr.yaml | 11 +++++++---- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/actions/evaluate-job-result/action.yaml b/.github/actions/evaluate-job-result/action.yaml index c76722df6624d..706053d6eb411 100644 --- a/.github/actions/evaluate-job-result/action.yaml +++ b/.github/actions/evaluate-job-result/action.yaml @@ -30,7 +30,7 @@ runs: for RESULT in "${EXPECTED[@]}"; do if [[ "$JOB_RESULT" == "$RESULT" ]]; then - echo "- ${{ inputs.job_name }}: Success ✅" >> "$GITHUB_STEP_SUMMARY" + echo "- **${{ inputs.job_name }}:** "$JOB_RESULT" ✅" >> "$GITHUB_STEP_SUMMARY" echo "failed=false" >> "$GITHUB_OUTPUT" exit 0 fi @@ -38,6 +38,6 @@ runs: # If no expected result matched echo "::error::${{ inputs.job_name }} failed. ❌" - "- ${{ inputs.job_name }}: Failed ❌" >> "$GITHUB_STEP_SUMMARY" + echo "- **${{ inputs.job_name }}:** failed ❌" >> "$GITHUB_STEP_SUMMARY" echo "failed=true" >> "$GITHUB_OUTPUT" shell: bash diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 7fdc8dcb85b47..096a937a3b3fb 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -128,8 +128,7 @@ jobs: - name: Check clang-tidy success if: ${{ needs.clang-tidy-differential.result == 'success' || needs.clang-tidy-differential-cuda.result == 'success' }} run: | - echo "All checks passed successfully! ✅" - echo "All checks passed successfully! ✅" >> $GITHUB_STEP_SUMMARY + echo "✅ Either one of the following has succeeded:" >> $GITHUB_STEP_SUMMARY - name: Fail if conditions not met if: ${{ !(needs.clang-tidy-differential.result == 'success' || needs.clang-tidy-differential-cuda.result == 'success') }} @@ -139,7 +138,11 @@ jobs: echo "::error::clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" echo "❌ Either one of the following should have succeeded:" >> $GITHUB_STEP_SUMMARY - echo "- clang-tidy-differential: ${{ needs.clang-tidy-differential.result }}" >> $GITHUB_STEP_SUMMARY - echo "- clang-tidy-differential-cuda: ${{ needs.clang-tidy-differential-cuda.result }}" >> $GITHUB_STEP_SUMMARY exit 1 + + - name: Print the results + if: ${{ always() }} + run: | + echo "- **clang-tidy-differential:** ${{ needs.clang-tidy-differential.result }}" >> $GITHUB_STEP_SUMMARY + echo "- **clang-tidy-differential-cuda:** ${{ needs.clang-tidy-differential-cuda.result }}" >> $GITHUB_STEP_SUMMARY From a9cdcebcc229c633f53a21df0e067aafc3e1874d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 18:52:45 +0300 Subject: [PATCH 10/15] simplify MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/actions/evaluate-job-result/action.yaml | 2 ++ .github/workflows/build-test-tidy-pr.yaml | 11 +---------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/actions/evaluate-job-result/action.yaml b/.github/actions/evaluate-job-result/action.yaml index 706053d6eb411..c5c013080fd27 100644 --- a/.github/actions/evaluate-job-result/action.yaml +++ b/.github/actions/evaluate-job-result/action.yaml @@ -40,4 +40,6 @@ runs: echo "::error::${{ inputs.job_name }} failed. ❌" echo "- **${{ inputs.job_name }}:** failed ❌" >> "$GITHUB_STEP_SUMMARY" echo "failed=true" >> "$GITHUB_OUTPUT" + + exit 1 shell: bash diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 096a937a3b3fb..34cd7c9c9f86e 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -80,6 +80,7 @@ jobs: expected_results: success - name: Evaluate build-and-test-differential-cuda + if: ${{ always() }} id: eval_cuda uses: ./.github/actions/evaluate-job-result with: @@ -87,16 +88,6 @@ jobs: job_name: build-and-test-differential-cuda expected_results: success,skipped - - name: Final Status - run: | - if [[ "${{ steps.eval_diff.outputs.failed }}" == "true" || "${{ steps.eval_cuda.outputs.failed }}" == "true" ]]; then - echo "Some checks failed. ❌" - exit 1 - else - echo "::notice::All checks passed successfully! ✅" - fi - shell: bash - clang-tidy-differential: needs: - check-if-cuda-job-is-needed From b6e4711f58f66bf419b135d6384cc00f81156419 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 23 Dec 2024 00:34:38 +0300 Subject: [PATCH 11/15] cuda package - good change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../autoware_lidar_apollo_instance_segmentation/src/node.cpp | 1 + .../include/mission_details_display.hpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp index 9a3e13b81120f..389fbef8f2daa 100644 --- a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp +++ b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp @@ -21,6 +21,7 @@ #include +// good change namespace autoware { namespace lidar_apollo_instance_segmentation diff --git a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp index 064e2021e2286..c3db6a2fec2ef 100644 --- a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp +++ b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp @@ -28,7 +28,7 @@ #include #include -#include +#include #include #include From ddd7caafd22c04fe2244e19542e2a9a632d8a4ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Mon, 23 Dec 2024 02:13:24 +0300 Subject: [PATCH 12/15] cuda package - bad change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../autoware_lidar_apollo_instance_segmentation/src/node.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp index 389fbef8f2daa..a0dd06e614c55 100644 --- a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp +++ b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp @@ -17,11 +17,10 @@ #include "autoware/lidar_apollo_instance_segmentation/detector.hpp" #include -#include +#include #include -// good change namespace autoware { namespace lidar_apollo_instance_segmentation From eac42cf01c189cd6fe1b1859fbe958839a2018c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 19:28:04 +0300 Subject: [PATCH 13/15] normal package - good change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../autoware_lidar_apollo_instance_segmentation/src/node.cpp | 2 +- .../include/mission_details_display.hpp | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp index a0dd06e614c55..9a3e13b81120f 100644 --- a/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp +++ b/perception/autoware_lidar_apollo_instance_segmentation/src/node.cpp @@ -17,7 +17,7 @@ #include "autoware/lidar_apollo_instance_segmentation/detector.hpp" #include -#include +#include #include diff --git a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp index c3db6a2fec2ef..7ad5fb81c128e 100644 --- a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp +++ b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp @@ -34,6 +34,7 @@ #include #endif +// test namespace autoware::mission_details_overlay_rviz_plugin { class MissionDetailsDisplay : public rviz_common::Display From 4421a18daeb03b3c696a58cf3a414fffb790b3f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 19:37:58 +0300 Subject: [PATCH 14/15] remove test changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .../include/mission_details_display.hpp | 1 - 1 file changed, 1 deletion(-) diff --git a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp index 7ad5fb81c128e..c3db6a2fec2ef 100644 --- a/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp +++ b/visualization/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/include/mission_details_display.hpp @@ -34,7 +34,6 @@ #include #endif -// test namespace autoware::mission_details_overlay_rviz_plugin { class MissionDetailsDisplay : public rviz_common::Display From 4e290243029ebcc37c9f3243022fae3b579514ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=2E=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 24 Dec 2024 19:56:32 +0300 Subject: [PATCH 15/15] remove unused ids MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: M. Fatih Cırıt --- .github/workflows/build-test-tidy-pr.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/build-test-tidy-pr.yaml b/.github/workflows/build-test-tidy-pr.yaml index 34cd7c9c9f86e..d1ea9b2d0f79d 100644 --- a/.github/workflows/build-test-tidy-pr.yaml +++ b/.github/workflows/build-test-tidy-pr.yaml @@ -72,7 +72,6 @@ jobs: shell: bash - name: Evaluate build-and-test-differential - id: eval_diff uses: ./.github/actions/evaluate-job-result with: job_result: ${{ needs.build-and-test-differential.result }} @@ -81,7 +80,6 @@ jobs: - name: Evaluate build-and-test-differential-cuda if: ${{ always() }} - id: eval_cuda uses: ./.github/actions/evaluate-job-result with: job_result: ${{ needs.build-and-test-differential-cuda.result }}