Skip to content

Conversation

@sarun-hub
Copy link

@sarun-hub sarun-hub commented Oct 2, 2025

Description

Several functions are ported to autoware_lanelet2_utils, thus deprecating them in autoware_lanelet2_extension.
Functions including:

  • getClosestSegment autoware_core PR # 621.
  • getLaneletAngle autoware_core PR # 621.
  • getClosestLaneletWithConstrains
  • getClosestCenterPoint autoware_core PR # 693.

How was this PR tested?

Notes for reviewers

Currently, build will always fail, because there are some usage of getClosestSegment and getLaneletAngle in some functions.

Make a copy of deprecated functions to use only in lanelet2_extension package during deprecation.

Effects on system behavior

None.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sarun-hub sarun-hub changed the title chore(lanelet2_extension): deprecated getClosestSegment and getLaneletAngle chore(lanelet2_extension): deprecate ported functions in lanelet2_extension Oct 31, 2025
@sarun-hub sarun-hub marked this pull request as ready for review October 31, 2025 04:39
@soblin soblin changed the title chore(lanelet2_extension): deprecate ported functions in lanelet2_extension [Merge later] chore(lanelet2_extension): deprecate ported functions in lanelet2_extension Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.97%. Comparing base (5a32788) to head (afcb6e9).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
autoware_lanelet2_extension/lib/utilities.cpp 0.00% 31 Missing ⚠️
autoware_lanelet2_extension/lib/query.cpp 0.00% 21 Missing ⚠️
autoware_lanelet2_extension_python/src/utility.cpp 0.00% 4 Missing ⚠️
...elet2_extension/test/src/test_normalize_radian.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   16.31%   17.97%   +1.66%     
==========================================
  Files          42       46       +4     
  Lines        3089     3054      -35     
  Branches     1397     1522     +125     
==========================================
+ Hits          504      549      +45     
+ Misses       2490     2377     -113     
- Partials       95      128      +33     
Flag Coverage Δ
differential 17.97% <0.00%> (+1.23%) ⬆️
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant