-
Notifications
You must be signed in to change notification settings - Fork 31
[Merge later] chore(lanelet2_extension): deprecate ported functions in lanelet2_extension #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Merge later] chore(lanelet2_extension): deprecate ported functions in lanelet2_extension #81
Conversation
Signed-off-by: Sarun Mukdapitak <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Sarun Mukdapitak <[email protected]>
Signed-off-by: Sarun Mukdapitak <[email protected]>
Signed-off-by: Sarun Mukdapitak <[email protected]>
Signed-off-by: Sarun Mukdapitak <[email protected]>
Signed-off-by: Sarun Mukdapitak <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 16.31% 17.97% +1.66%
==========================================
Files 42 46 +4
Lines 3089 3054 -35
Branches 1397 1522 +125
==========================================
+ Hits 504 549 +45
+ Misses 2490 2377 -113
- Partials 95 128 +33
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Several functions are ported to
autoware_lanelet2_utils, thus deprecating them inautoware_lanelet2_extension.Functions including:
getClosestSegmentautoware_core PR # 621.getLaneletAngleautoware_core PR # 621.getClosestLaneletWithConstrainsgetClosestCenterPointautoware_core PR # 693.How was this PR tested?
Notes for reviewers
Currently, build will always fail, because there are some usage ofgetClosestSegmentandgetLaneletAnglein some functions.Make a copy of deprecated functions to use only in
lanelet2_extensionpackage during deprecation.Effects on system behavior
None.