fix(autoware_perception_rviz_plugin): fix calc_path_line_list
#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 11
Lines ? 1271
Branches ? 150
======================================
Hits ? 0
Misses ? 1271
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
SakodaShintaro
requested review from
a team,
1222-takeshi,
YoshiRi and
taikitanaka3
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
calc_path_line_listfunction to properly calculate yaw angles from path orientations instead of relying solely on line direction calculations.How was this PR tested?
Run the planning simulation and set some vehicles.
The problem mainly occurs in the prediction by the Diffusion Planner. If the position of the PredictedObject fluctuates slightly, it will point in various directions, resulting in a circular shape in the Before image. This has been corrected in the After image.
The moving car appears natural in both images.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.