fix(lareral_deviation_monitor): update metrics msgs #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayuki5168
approved these changes
Nov 20, 2024
Kazunori-Nakajima
requested review from
Motsu-san,
SakodaShintaro,
TaikiYamada4,
YamatoAndo,
anhnv3991 and
soblin
as code owners
Kazunori-Nakajima
force-pushed
the
fix_metrics_msgs
branch
from
b1ad945 to
a6e99ad
Compare
kosuke55
approved these changes
Nov 20, 2024
xtk8532704
approved these changes
Nov 21, 2024
|
I don’t really mind since it’s not related to me, but adding CORDOWNER should be written in the package.xml. |
|
YamatoAndo-san, Thank you very much!!! |
kosuke55
force-pushed
the
fix_metrics_msgs
branch
from
2c55e7c to
9e62c7f
Compare
Kazunori-Nakajima
added
tag:run-build-and-test-differential
and removed
tag:run-build-and-test-differential
labels
Signed-off-by: Kasunori-Nakajima <[email protected]>
Signed-off-by: Kasunori-Nakajima <[email protected]>
Signed-off-by: Kasunori-Nakajima <[email protected]>
kosuke55
force-pushed
the
fix_metrics_msgs
branch
from
9e62c7f to
b2c8f8e
Compare
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
|
@Kazunori-Nakajima Friendly ping. It's 4 month stale. Though I'm not related to this change, I think the CODEOWNERS change is not needed, only the package.xml change is needed.(TBH, It is preferable to split it and submit pull requests.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a related links PR,
/control/contol_evaluator/metricswas changed from DiagnosticArray to MetricArray.This change caused B to not take msgs well and not receive msgs, which has been corrected.Added @kosuke55 san and @xtk8532704 san to CORDOWNER.
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.