Skip to content

Conversation

@TaikiYamada4
Copy link
Contributor

Description

This PR provides lanelet2_map_validator a versioning structure.
This PR does the following.

  • States the initial version of lanelet2_map_validator in package.xml
    • Export package.xml to the share directory to read the package version.
  • Adds a tentative map requirement version to autoware_requirement_set.json
  • Adds a feature that stamps a validation tag to the .osm file that describes the map is validated by "what validator" with "what validator version" reflecting "what kind of map requirements" with "what requirement version".
  • Stated a document how to control versions for lanelet2_map_validator.

How was this PR tested?

1. Checked that general usage works fine with the new versioning feature

The following command works fine.

ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator -p mgrs -m sample_map.osm -i ./install/autoware_lanelet2_map_validator/share/autoware_lanelet2_map_validator/autoware_requirement_set.json -o ./

AND one can find a validation tag like this in the osm file.

<validation name="autoware_lanelet2_map_validator" validator_version="1.0.0" requirements="autoware_requirement_set.json" requirements_version="0.0.0" />

2. Checked that colcon test works fine

The following command works fine.

colcon test --packages-select autoware_lanelet2_map_validator --event-handlers console_cohesion+

Notes for reviewers

I also wanted to put information whether the validation passed or not, but it requires to change the structure of process_requirements function. I will do that later and do not add this feature here.

Effects on system behavior

None.

@github-actions
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant