-
Notifications
You must be signed in to change notification settings - Fork 773
ci(build-and-test*): run above with self-hosted, remove taskset limit #11099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@@ -70,7 +71,6 @@ jobs: | |||
container-suffix: -cuda | |||
run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'true' }} | |||
runner: "['self-hosted', 'Linux', 'X64']" | |||
build-pre-command: taskset --cpu-list 0-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitsudome-r I also realized this was left here 🤦♂️
We forgot it since we introduced the larger OVH machines https://github.com/autowarefoundation/autoware_universe/blame/d24b1ec68c029fb8426ca069e8ed7707408d786c/.github/workflows/build-test-tidy-pr.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11099 +/- ##
==========================================
+ Coverage 20.29% 22.85% +2.56%
==========================================
Files 1489 1497 +8
Lines 108621 109368 +747
Branches 35693 35974 +281
==========================================
+ Hits 22041 24993 +2952
- Misses 69556 69819 +263
+ Partials 17024 14556 -2468
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b5e8b29
to
4fbcc99
Compare
Again failed with 30 secs timeout
|
On my high spec home PC test 7 took For the failing test 8, my PC took This means we can just increase the timeout from 30s to 90s and hope it gets resolved.
vs CI
|
|
Signed-off-by: M. Fatih Cırıt <[email protected]>
4fbcc99
to
3e64c0b
Compare
I will remove the dummy change and we can proceed to merge this. |
3e64c0b
to
e803c21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.