Skip to content

ci(build-and-test*): run above with self-hosted, remove taskset limit #11099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jul 31, 2025

Description

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@xmfcx xmfcx marked this pull request as draft July 31, 2025 15:17
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jul 31, 2025
Copy link

github-actions bot commented Jul 31, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 31, 2025
@@ -70,7 +71,6 @@ jobs:
container-suffix: -cuda
run-condition: ${{ needs.check-if-cuda-job-is-needed.outputs.cuda_job_is_needed == 'true' }}
runner: "['self-hosted', 'Linux', 'X64']"
build-pre-command: taskset --cpu-list 0-6
Copy link
Contributor Author

@xmfcx xmfcx Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitsudome-r I also realized this was left here 🤦‍♂️

We forgot it since we introduced the larger OVH machines https://github.com/autowarefoundation/autoware_universe/blame/d24b1ec68c029fb8426ca069e8ed7707408d786c/.github/workflows/build-test-tidy-pr.yaml

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.85%. Comparing base (400b4c6) to head (3e64c0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11099      +/-   ##
==========================================
+ Coverage   20.29%   22.85%   +2.56%     
==========================================
  Files        1489     1497       +8     
  Lines      108621   109368     +747     
  Branches    35693    35974     +281     
==========================================
+ Hits        22041    24993    +2952     
- Misses      69556    69819     +263     
+ Partials    17024    14556    -2468     
Flag Coverage Δ *Carryforward flag
daily 21.92% <ø> (ø) Carriedforward from 400b4c6
daily-cuda 20.37% <ø> (ø) Carriedforward from 400b4c6
differential 35.24% <ø> (?)
total-cuda 20.27% <ø> (ø) Carriedforward from 400b4c6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xmfcx xmfcx force-pushed the ci/fix-flaky-above-test branch from b5e8b29 to 4fbcc99 Compare July 31, 2025 15:45
@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 31, 2025

Again failed with 30 secs timeout ☹️ :

8: [main-3] [WARN] [1753978160.230954053] [path_generator.utils.connect_path_to_goal]: Failed to find closest point to goal, returning input as is
 8/10 Test  #8: test_test_static_centerline_generator_path_generator_case3_launch.test.py ...***Timeout  30.00 sec

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 31, 2025

On my high spec home PC test 7 took 5.94s when the one on the CI took 17.02s for the same test.

For the failing test 8, my PC took 11.28s to complete it so it would make sense that it takes longer than 30s for the CI machine.

This means we can just increase the timeout from 30s to 90s and hope it gets resolved.

7/10 Test  #7: test_test_static_centerline_generator_path_generator_case2_launch.test.py ...   Passed    5.94 sec

vs CI

7/10 Test  #7: test_test_static_centerline_generator_path_generator_case2_launch.test.py ...   Passed   17.02 sec

@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 31, 2025

@xmfcx xmfcx force-pushed the ci/fix-flaky-above-test branch from 4fbcc99 to 3e64c0b Compare August 1, 2025 14:04
@xmfcx
Copy link
Contributor Author

xmfcx commented Aug 1, 2025

All green! https://github.com/autowarefoundation/autoware_universe/actions/runs/16677113983/job/47206363936?pr=11099

I will remove the dummy change and we can proceed to merge this.

@xmfcx xmfcx force-pushed the ci/fix-flaky-above-test branch from 3e64c0b to e803c21 Compare August 1, 2025 16:26
@github-actions github-actions bot removed the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 1, 2025
@xmfcx xmfcx requested review from mitsudome-r and removed request for kyoichi-sugahara, kosuke55, shmpwk, satoshi-ota and tkimura4 August 1, 2025 16:27
@xmfcx xmfcx marked this pull request as ready for review August 1, 2025 16:27
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xmfcx xmfcx merged commit f3260f9 into main Aug 1, 2025
26 of 27 checks passed
@xmfcx xmfcx deleted the ci/fix-flaky-above-test branch August 1, 2025 16:32
@github-project-automation github-project-automation bot moved this from To Triage to Done in Software Working Group Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix flaky test: test_static_centerline_generator_path_generator_case3_launch.test.py
2 participants