Skip to content

Commit ce81795

Browse files
authored
chore: regular properties instead of raw fields used (#311)
1 parent 0e0da0b commit ce81795

File tree

12 files changed

+232
-202
lines changed

12 files changed

+232
-202
lines changed

src/main/groovy/com/avast/gradle/dockercompose/ComposeExecutor.groovy

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,20 @@ class ComposeExecutor {
4343
void executeWithCustomOutput(OutputStream os, Boolean ignoreExitValue, Boolean noAnsi, Boolean captureStderr, String... args) {
4444
def settings = this.settings
4545
def er = exec.exec { ExecSpec e ->
46-
if (settings.dockerComposeWorkingDirectory) {
47-
e.setWorkingDir(settings.dockerComposeWorkingDirectory)
46+
if (settings.dockerComposeWorkingDirectory.isPresent()) {
47+
e.setWorkingDir(settings.dockerComposeWorkingDirectory.get().asFile)
4848
}
49-
e.environment = settings.environment
50-
def finalArgs = [settings.executable]
51-
finalArgs.addAll(settings.composeAdditionalArgs)
49+
e.environment = settings.environment.get()
50+
def finalArgs = [settings.executable.get()]
51+
finalArgs.addAll(settings.composeAdditionalArgs.get())
5252
if (noAnsi) {
5353
if (version >= VersionNumber.parse('1.28.0')) {
5454
finalArgs.addAll(['--ansi', 'never'])
5555
} else if (version >= VersionNumber.parse('1.16.0')) {
5656
finalArgs.add('--no-ansi')
5757
}
5858
}
59-
finalArgs.addAll(settings.useComposeFiles.collectMany { ['-f', it].asCollection() })
59+
finalArgs.addAll(settings.useComposeFiles.get().collectMany { ['-f', it].asCollection() })
6060
String pn = settings.projectName
6161
if (pn) {
6262
finalArgs.addAll(['-p', pn])
@@ -73,7 +73,7 @@ class ComposeExecutor {
7373
}
7474
if (!ignoreExitValue && er.exitValue != 0) {
7575
def stdout = os != null ? os.toString().trim() : "N/A"
76-
throw new RuntimeException("Exit-code ${er.exitValue} when calling ${settings.executable}, stdout: $stdout")
76+
throw new RuntimeException("Exit-code ${er.exitValue} when calling ${settings.executable.get()}, stdout: $stdout")
7777
}
7878
}
7979

@@ -149,20 +149,20 @@ class ComposeExecutor {
149149
}
150150

151151
Iterable<String> getServiceNames() {
152-
if (!settings.startedServices.empty) {
153-
if(settings.includeDependencies)
152+
if (!settings.startedServices.get().empty) {
153+
if(settings.includeDependencies.get())
154154
{
155-
def dependentServices = getDependentServices(settings.startedServices).toList()
156-
[*settings.startedServices, *dependentServices].unique()
155+
def dependentServices = getDependentServices(settings.startedServices.get()).toList()
156+
[*settings.startedServices.get(), *dependentServices].unique()
157157
}
158158
else
159159
{
160-
settings.startedServices
160+
settings.startedServices.get()
161161
}
162162
} else if (version >= VersionNumber.parse('1.6.0')) {
163163
execute('config', '--services').readLines()
164164
} else {
165-
def composeFiles = settings.useComposeFiles.empty ? getStandardComposeFiles() : getCustomComposeFiles()
165+
def composeFiles = settings.useComposeFiles.get().empty ? getStandardComposeFiles() : getCustomComposeFiles()
166166
composeFiles.collectMany { composeFile ->
167167
def compose = (Map<String, Object>) (new Yaml().load(fileOps.file(composeFile).text))
168168
// if there is 'version' on top-level then information about services is in 'services' sub-tree
@@ -193,7 +193,7 @@ class ComposeExecutor {
193193
}
194194

195195
Iterable<File> getCustomComposeFiles() {
196-
settings.useComposeFiles.collect {
196+
settings.useComposeFiles.get().collect {
197197
def f = fileOps.file(it)
198198
if (!f.exists()) {
199199
throw new IllegalArgumentException("Custom Docker Compose file not found: $f")

0 commit comments

Comments
 (0)