Skip to content

Commit f48270d

Browse files
aykborstelmannaugi
authored andcommitted
fix: Make default project name lowercase, fixes #378
1 parent 960adc4 commit f48270d

File tree

2 files changed

+30
-1
lines changed

2 files changed

+30
-1
lines changed

src/main/groovy/com/avast/gradle/dockercompose/ComposeSettings.groovy

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,10 @@ abstract class ComposeSettings {
101101
else {
102102
return "${safeProjectNamePrefix}_${nestedName}"
103103
}
104-
})
104+
}).map{ String projectName ->
105+
// docker-compose project names must be lowercase
106+
projectName.toLowerCase()
107+
}
105108

106109
useComposeFiles.empty()
107110
startedServices.empty()

src/test/groovy/com/avast/gradle/dockercompose/DockerComposePluginTest.groovy

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,32 @@ class DockerComposePluginTest extends Specification {
8181
up.composeExecutor.get().parameters.useComposeFiles.get() == ['test.yml']
8282
}
8383

84+
def "project name should always be lowercase"() {
85+
def project = ProjectBuilder.builder().build()
86+
when:
87+
project.plugins.apply 'docker-compose'
88+
project.dockerCompose {
89+
nestedUppercaseTask {
90+
useComposeFiles = ['docker-compose.yml']
91+
}
92+
nestedUppercaseProjectName {
93+
projectNamePrefix = "UPPERCASE"
94+
}
95+
nestedUppercaseProjectNamePrefix {
96+
projectNamePrefix = "UPPERCASE"
97+
}
98+
}
99+
100+
then:
101+
102+
['nestedUppercaseTask', 'nestedUppercaseProjectName'].forEach{ String config ->
103+
def projectName = project.dockerCompose."$config".projectName.get()
104+
assert projectName.toLowerCase() == projectName
105+
}
106+
107+
108+
}
109+
84110
def "is possible to access servicesInfos of nested setting"() {
85111
def project = ProjectBuilder.builder().build()
86112
when:

0 commit comments

Comments
 (0)