Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Visually mark found strings without hovering #66

Open
ruppde opened this issue Oct 23, 2023 · 2 comments
Open

Feature request: Visually mark found strings without hovering #66

ruppde opened this issue Oct 23, 2023 · 2 comments

Comments

@ruppde
Copy link
Contributor

ruppde commented Oct 23, 2023

The logical next step after #63 would to visually mark found strings without hovering.

Could look like this: You open a .yar and immediately see by the blue numbers, in how many hashes these strings match:

{
	meta:
                ...
		hash = "0e9d92807d990144c637d8b081a6a90a74f15c7337522874cf6317092ea2d7c1"
		hash = "ebbc485e778f8e559ef9c66f55bb01dc4f5dcce9c31ccdd150e2c702c4b5d9e1"
		hash = "44b4068bfbbb8961e16bae238ad23d181ac9c8e4fcb4b09a66bbcd934d2d39ee"
		hash = "c5a4e188780b5513f34824904d56bf6e364979af6782417ccc5e5a8a70b4a95a"
	strings:
		2️⃣ $susasp1 = "/*-/*-*/"
		0️⃣ $susasp2 = "(\"%1"
		1️⃣ $susasp3 = /[Cc]hr\([Ss]tr\(/
		2️⃣ $susasp4 = "cmd.exe"
                ...

After clicking on the magnifying lens next to the hashes, you see which strings match for this hash by ✅ or ❌ next to the strings without need to hover.

I just don't have a clue how this could be done with LSP :)

@MatejKastak
Copy link
Member

Good suggestion! I think we might be able to do something similar using inlay hints.

@ruppde
Copy link
Contributor Author

ruppde commented Oct 24, 2023

Looks promising. If we get this working, there would be gazillion more things to mark with that:

  • hash not found, not found but on VT, found locally and rule matched, rule didn't match
  • rule changed but modified-header is not today
  • do quality check with e.g. https://github.com/Neo23x0/yaraQA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants