Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature bytes wrong for a number of devices #877

Open
stefanrueger opened this issue Mar 7, 2022 · 2 comments
Open

Signature bytes wrong for a number of devices #877

stefanrueger opened this issue Mar 7, 2022 · 2 comments

Comments

@stefanrueger
Copy link

Some SIGNATURE_2 values are wrong in io header files.

iom164.h should be:

#if defined(__AVR_ATmega164A__)
#define SIGNATURE_2 0x0F
#else
#define SIGNATURE_2 0x0A
#endif

iom324.h should be

#if defined(__AVR_ATmega324A__)
#define SIGNATURE_2 0x15
#else
#define SIGNATURE_2 0x08
#endif

see datasheet page 298


iom169.h should be

#if defined(__AVR_ATmega169A__)
#define SIGNATURE_2 0x11
#else
#define SIGNATURE_2 0x05
#endif

iom329.h should be

#if defined (__AVR_ATmega329P__) || defined (__AVR_ATmega329PA__)   
#define SIGNATURE_2 0x0B
#else
#define SIGNATURE_2 0x03
#endif

iom3290.h should be

#if defined (__AVR_ATmega3290P__)
#define SIGNATURE_2 0x0C
#else
#define SIGNATURE_2 0x04
#endif

iom6490.h should be

#if defined (__AVR_ATmega6490P__)
#define SIGNATURE_2 0x0C
#else
#define SIGNATURE_2 0x04
#endif

see datasheet 169/329/p/pa, page 294
and datasheet 329p page 299


iom325.h should be

#if defined (__AVR_ATmega325P__)
#define SIGNATURE_2 0x0D
#else
#define SIGNATURE_2 0x05
#endif

iom645.h should be

#if defined (__AVR_ATmega645P__)
#define SIGNATURE_2 0x0D
#else
#define SIGNATURE_2 0x05
#endif

iom3250.h should be

#if defined (__AVR_ATmega3250P__)
#define SIGNATURE_2 0x0E
#else
#define SIGNATURE_2 0x06
#endif

iom6450.h should be

#if defined (__AVR_ATmega6450P__)
#define SIGNATURE_2 0x0E
#else
#define SIGNATURE_2 0x06
#endif

see datasheet 165/325/p/pa, page 264
and datasheet 325p page 274

@dl8dtl
Copy link
Contributor

dl8dtl commented Mar 7, 2022

#if defined (__AVR_ATmega325P__)

This lacks the ATmega325PA which also needs 0x0D (see ATDF file).

@stefanrueger
Copy link
Author

More wrong signature bytes:

iotn4.h and iotn5.h should define SIGNATURE_1 to 0x8F (not 0x90). See .atdf files and avrdude signature entries.


io4434.h should define SIGNATURE_1 to 0x92 (not 0x93). See avrdude signature entries (consistent with 0x92 typically implying 4 kB flash).

It also should define SIGNATURE_2 to 0x02 (not 0x03). See avrdude signature entries. The signatures that are currently defined for the AT90S4434 are actually those from the AT90S8535.


Following the change of signature in avrdude for the ATmega165, the file iom165.h should now define SIGNATURE_2 as 0x10. See avrdude issue 899 and commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants