Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error since yesterday as - Unexpected key 'enableFaultInjection' found in params #705

Open
rithik-choudhary opened this issue Jan 8, 2025 · 16 comments
Labels
feature-request A feature should be added or improved.

Comments

@rithik-choudhary
Copy link

Hello,

we are running the workflow file with same configuration since 1 year and suddenly from yesterday we are facing this issue
error
Error: Failed to register task definition in ECS: Unexpected key 'enableFaultInjection' found in params Error: Unexpected key 'enableFaultInjection' found in params

this the line of code in workflow file

    - name: Fill in the new image ID in the Amazon ECS task definition
       id: service-task-def
       uses: aws-actions/amazon-ecs-render-task-definition@v1  # Updated to v1
       with:
         task-definition: ./app-task-definition-fixed.json
         container-name: ${{ env.CONTAINER_NAME }}
         image: ${{ steps.build-image.outputs.image }}

Need help to resolve this issue quickly

@rithik-choudhary rithik-choudhary added the feature-request A feature should be added or improved. label Jan 8, 2025
@vhoigs
Copy link

vhoigs commented Jan 8, 2025

Hey @rithik-choudhary I was able to solve this by bumping the version to v2. Hope that helps!

@landon-medme
Copy link

Hey @rithik-choudhary I was able to solve this by bumping the version to v2. Hope that helps!

Upgrading to v2 fixed the issue for me 👍

@omkhegde
Copy link
Contributor

omkhegde commented Jan 8, 2025

Hello. As other users have pointed out, please use v2 version of the action to fix this issue. Closing this issue, but please feel free to comment if there are follow-up questions.

@omkhegde omkhegde closed this as completed Jan 8, 2025
@jo-mpac
Copy link

jo-mpac commented Jan 8, 2025

May I ask what was the reason that caused this issue? There are no changes in either v1 or v2 branches recently... Was it something on the AWS API side? Thank you and Happy New Year :)

@thanshaw02
Copy link

Updating the version to v2 also did the trick for me, thank you!

@luizhlelis
Copy link

upgrading to v2 fixed the issue for me as well

@omkhegde
Copy link
Contributor

omkhegde commented Jan 9, 2025

Hi all, thank you for reporting this issue. We have identified an issue in one of ECS' backend APIs that introduced a backward incompatible change, causing user workflows to encounter Error: Failed to register task definition in ECS: Unexpected key 'enableFaultInjection' found in params Error: Unexpected key 'enableFaultInjection' found in params error. We are actively working on a fix for the issue, and will update this issue once it's resolved. Thank you.

@omkhegde omkhegde reopened this Jan 9, 2025
@cavelasquez17
Copy link

I switched to v2, and now I'm getting the error when deploying to prod: {"state":"TIMEOUT","reason":"Waiter has timed out"}

@bnk222
Copy link

bnk222 commented Jan 10, 2025

i switched to v2 but i am getting Unable to resolve action aws-actions/amazon-ecs-render-task-definition@v2, unable to find version v2

@bnk222
Copy link

bnk222 commented Jan 10, 2025

only switch this aws-actions/amazon-ecs-deploy-task-definition@v1 -> aws-actions/amazon-ecs-deploy-task-definition@v2

@paulmothapo
Copy link

If updating to v2 still causes an error, try to remove the line containing "enableFaultInjection":false in the task-definition.json

@fabiendeborde
Copy link

It was working fine with v2 until about an hour ago and now I am also getting an error:
{"state":"TIMEOUT","reason":"Waiter has timed out"}

@omkhegde
Copy link
Contributor

Hello, for the error messages like Waiter has timed out, we had received a similar issue in the past which was caused by missing IAM permissions (#608). Could you please check whether adding permissions as mentioned in #608 resolves the error?

Thank you.

@char-yb
Copy link

char-yb commented Jan 14, 2025

image

Hello, Errors such as 'Unexpected key 'enableFaultInjection' found in parameters' are still occurring.
I wonder how the error has been resolved.

      - name: Fill in the new image ID in the Amazon ECS task definition
        id: task-def
        uses: aws-actions/amazon-ecs-render-task-definition@v1
        with:
          task-definition: task-definition.json
          container-name: ${{ env.ECR_CONTAINER_NAME }}
          image: ${{ steps.build-image.outputs.image }}
      - name: Deploy Amazon ECS task definition
        uses: aws-actions/amazon-ecs-deploy-task-definition@v1
        with:
          task-definition: ${{ steps.task-def.outputs.task-definition }}
          service: ${{ env.ECS_CONTAINER_SERVICE_NAME }}
          cluster: ${{ env.ECS_CLUSTER_NAME }}
          wait-for-service-stability: true

Im currently using it in this yml, which looks like the top.

@paulmothapo
Copy link

@char-yb update aws-actions/amazon-ecs-deploy-task-definition@v1 to v2

@habdelra
Copy link

habdelra commented Jan 14, 2025

When I switched to v2 I started seeing the message: {"state":"TIMEOUT","reason":"Waiter has timed out"}. When I set wait-for-service-stability to false this message went away. Is there a change to how waiting for service stability occurs in v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests