Plugin configuration requirement removed (#333)

Author: raphkim

aws-analytics-pinpoint/src/main/java/com/amplifyframework/analytics/pinpoint/AmazonPinpointAnalyticsPlugin.java

@@ -305,7 +305,17 @@ public String getPluginKey() {
      * {@inheritDoc}
      */
     @Override
-    public void configure(@NonNull JSONObject pluginConfiguration, @NonNull Context context) throws AnalyticsException {
+    public void configure(
+            JSONObject pluginConfiguration,
+            @NonNull Context context
+    ) throws AnalyticsException {
+        if (pluginConfiguration == null) {
+            throw new AnalyticsException(
+                    "Missing configuration for " + getPluginKey(),
+                    "Check amplifyconfiguration.json to make sure that there is a section for " +
+                            getPluginKey() + " under the analytics category."
+            );
+        }
 
         AmazonPinpointAnalyticsPluginConfiguration.Builder configurationBuilder =
                 AmazonPinpointAnalyticsPluginConfiguration.builder();
@@ -344,7 +354,7 @@ public void configure(@NonNull JSONObject pluginConfiguration, @NonNull Context
                 "Unable to read appId or region from the amplify configuration json.",
                 exception,
                 "Make sure amplifyconfiguration.json is a valid json object in expected format. " +
-                "Please take a look at the documentation for expected format of amplifyconfiguration.json."
+                    "Please take a look at the documentation for expected format of amplifyconfiguration.json."
             );
         }
 

aws-api/src/main/java/com/amplifyframework/api/aws/AWSApiPlugin.java

@@ -101,10 +101,13 @@ public String getPluginKey() {
     }
 
     @Override
-    public void configure(@NonNull JSONObject pluginConfigurationJson, @NonNull Context context) throws ApiException {
+    public void configure(
+            JSONObject pluginConfiguration,
+            @NonNull Context context
+    ) throws ApiException {
         // Null-check for configuration is done inside readFrom method
         AWSApiPluginConfiguration pluginConfig =
-                AWSApiPluginConfigurationReader.readFrom(pluginConfigurationJson);
+                AWSApiPluginConfigurationReader.readFrom(pluginConfiguration);
 
         final InterceptorFactory interceptorFactory =
                 new AppSyncSigV4SignerInterceptorFactory(authProvider);

aws-datastore/src/main/java/com/amplifyframework/datastore/AWSDataStorePlugin.java

@@ -107,11 +107,12 @@ public String getPluginKey() {
     @SuppressLint("CheckResult")
     @Override
     public void configure(
-            @Nullable JSONObject pluginConfigurationJson,
-            @NonNull Context context) throws DataStoreException {
+            JSONObject pluginConfiguration,
+            @NonNull Context context
+    ) throws DataStoreException {
         try {
             this.pluginConfiguration =
-                AWSDataStorePluginConfiguration.fromJson(pluginConfigurationJson);
+                AWSDataStorePluginConfiguration.fromJson(pluginConfiguration);
         } catch (DataStoreException badConfigException) {
             throw new DataStoreException(
                 "There was an issue configuring the plugin from the amplifyconfiguration.json",

aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/AWSS3StoragePlugin.java

@@ -107,7 +107,10 @@ public String getPluginKey() {
 
     @Override
     @SuppressWarnings("MagicNumber") // TODO: Remove once default values are moved to configuration
-    public void configure(@NonNull JSONObject pluginConfiguration, @NonNull Context context) throws StorageException {
+    public void configure(
+            JSONObject pluginConfiguration,
+            @NonNull Context context
+    ) throws StorageException {
         String regionStr;
         String bucket;
 

core/src/main/java/com/amplifyframework/core/plugin/Plugin.java

@@ -54,14 +54,17 @@ public interface Plugin<E> extends CategoryTypeable {
     String getPluginKey();
 
     /**
-     * Configure the plugin with customized configuration object.
+     * Configure the plugin with customized configuration object. A
+     * plugin may or may not require plugin configuration, so see
+     * the documentation for details.
+     *
      * This hook provides a good opportunity to instantiate resources.
      * Any long-lived initialization should take place in {@link #initialize(Context)}, instead.
      * @param pluginConfiguration plugin-specific configuration data
      * @param context An Android Context
      * @throws AmplifyException an error is encountered during configuration.
      */
-    void configure(@NonNull JSONObject pluginConfiguration, @NonNull Context context) throws AmplifyException;
+    void configure(JSONObject pluginConfiguration, @NonNull Context context) throws AmplifyException;
 
     /**
      * Initializes the plugin.

core/src/main/java/com/amplifyframework/hub/AWSHubPlugin.java

@@ -131,7 +131,7 @@ public String getPluginKey() {
     }
 
     @Override
-    public void configure(@NonNull JSONObject pluginConfiguration, @NonNull Context context) {
+    public void configure(JSONObject pluginConfiguration, @NonNull Context context) {
     }
 
     @Nullable

core/src/main/java/com/amplifyframework/logging/AndroidLoggingPlugin.java

@@ -66,7 +66,7 @@ public String getPluginKey() {
 
     @Override
     public void configure(
-            @NonNull JSONObject pluginConfiguration,
+            JSONObject pluginConfiguration,
             @NonNull Context context)
             throws LoggingException {
         // In the future, accept a log level configuration from JSON?