Skip to content

Commit a870cf9

Browse files
chore: carry some annotations down to implementations (#877)
Return types on GraphQLRequestOptions wear @nonnull annotations, but the implementing classes did not also do so. This is quick touchup to add them to the implementing classes, too.
1 parent 6699348 commit a870cf9

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

aws-api-appsync/src/test/java/com/amplifyframework/api/aws/DefaultGraphQLRequestOptions.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,28 @@
1515

1616
package com.amplifyframework.api.aws;
1717

18+
import androidx.annotation.NonNull;
19+
1820
import java.util.Collections;
1921
import java.util.List;
2022

2123
public final class DefaultGraphQLRequestOptions implements GraphQLRequestOptions {
2224
private static final String ITEMS_KEY = "items";
2325
private static final String NEXT_TOKEN_KEY = "nextToken";
2426

27+
@NonNull
2528
@Override
2629
public List<String> paginationFields() {
2730
return Collections.singletonList(NEXT_TOKEN_KEY);
2831
}
2932

33+
@NonNull
3034
@Override
3135
public List<String> modelMetaFields() {
3236
return Collections.emptyList();
3337
}
3438

39+
@NonNull
3540
@Override
3641
public String listField() {
3742
return ITEMS_KEY;
@@ -42,6 +47,7 @@ public int maxDepth() {
4247
return 2;
4348
}
4449

50+
@NonNull
4551
@Override
4652
public LeafSerializationBehavior leafSerializationBehavior() {
4753
return LeafSerializationBehavior.ALL_FIELDS;

aws-api/src/main/java/com/amplifyframework/api/aws/ApiGraphQLRequestOptions.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515

1616
package com.amplifyframework.api.aws;
1717

18+
import androidx.annotation.NonNull;
19+
1820
import java.util.Collections;
1921
import java.util.List;
2022

@@ -25,16 +27,19 @@ public final class ApiGraphQLRequestOptions implements GraphQLRequestOptions {
2527
private static final String ITEMS_KEY = "items";
2628
private static final String NEXT_TOKEN_KEY = "nextToken";
2729

30+
@NonNull
2831
@Override
2932
public List<String> paginationFields() {
3033
return Collections.singletonList(NEXT_TOKEN_KEY);
3134
}
3235

36+
@NonNull
3337
@Override
3438
public List<String> modelMetaFields() {
3539
return Collections.emptyList();
3640
}
3741

42+
@NonNull
3843
@Override
3944
public String listField() {
4045
return ITEMS_KEY;
@@ -45,6 +50,7 @@ public int maxDepth() {
4550
return 2;
4651
}
4752

53+
@NonNull
4854
@Override
4955
public LeafSerializationBehavior leafSerializationBehavior() {
5056
return LeafSerializationBehavior.ALL_FIELDS;

aws-datastore/src/main/java/com/amplifyframework/datastore/appsync/DataStoreGraphQLRequestOptions.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515

1616
package com.amplifyframework.datastore.appsync;
1717

18+
import androidx.annotation.NonNull;
19+
1820
import com.amplifyframework.api.aws.GraphQLRequestOptions;
1921
import com.amplifyframework.api.aws.LeafSerializationBehavior;
2022

@@ -32,16 +34,19 @@ public final class DataStoreGraphQLRequestOptions implements GraphQLRequestOptio
3234
private static final String VERSION_KEY = "_version";
3335
private static final String LAST_CHANGED_AT_KEY = "_lastChangedAt";
3436

37+
@NonNull
3538
@Override
3639
public List<String> paginationFields() {
3740
return Arrays.asList(NEXT_TOKEN_KEY, STARTED_AT_KEY);
3841
}
3942

43+
@NonNull
4044
@Override
4145
public List<String> modelMetaFields() {
4246
return Arrays.asList(VERSION_KEY, DELETED_KEY, LAST_CHANGED_AT_KEY);
4347
}
4448

49+
@NonNull
4550
@Override
4651
public String listField() {
4752
return ITEMS_KEY;
@@ -52,6 +57,7 @@ public int maxDepth() {
5257
return 1;
5358
}
5459

60+
@NonNull
5561
@Override
5662
public LeafSerializationBehavior leafSerializationBehavior() {
5763
return LeafSerializationBehavior.JUST_ID;

0 commit comments

Comments
 (0)