fix(auth): Fix losing session identifier when incorrect otp code is entered during confirm sign up

[mattcreaser]

• PR title and description conform to Pull Request guidelines.

Issue #, if available: #3135

Description of changes:
Fixes one of the issues identified in the linked bug. When a user entered an incorrect confirmation code during confirmSignUp we would enter an Error state. During a correct subsequent confirmSignUp call we would not pass the existing Cognito session identifier. If there are no passwordless options enabled for the user pool, this would result in Cognito throwing a SelectChallenge which would cause Amplify to hang.

This fix retains the signUpData during the error state so that the session can be continued on subsequent calls to confirmSignUp. This allows Cognito to recognize the password entered during initial sign up, allowing autoSignIn to succeed.

Fixing autoSignIn hanging on SelectChallenge is a much larger fix that will be tackled separately.

How did you test these changes?

• Verified that autoSignIn works as expected after entering an incorrect confirmation code after creating an account.

Documentation update required?

• No
• Yes (Please include a PR link for the documentation update)

General Checklist

• Added Unit Tests
• Added Integration Tests
• Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
• Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.28%. Comparing base (288a082) to head (826f4b7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
+ Coverage   54.27%   54.28%   +0.01%     
==========================================
  Files        1040     1040              
  Lines       32071    32082      +11     
  Branches     4712     4726      +14     
==========================================
+ Hits        17406    17416      +10     
+ Misses      12824    12819       -5     
- Partials     1841     1847       +6     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.