fix(e2e): local e2e test hanging for sendYes
#13010
Conversation
| # Used for cleanup script | ||
| CIRCLECI_TOKEN = '<your token>' # Token used for querying CircleCI to get the build details | ||
| CIRCLE_PROJECT_USERNAME='<your github username>' | ||
| CIRCLE_PROJECT_REPONAME='amplify-cli' | ||
|
|
||
| AMPLIFY_PATH= |
There was a problem hiding this comment.
Please add comment that explains what this does.
Something like # A path to Amplify CLI executable. When working locally it should be set to bin/amplify file in the workspace, for example <insert example here> if running regular e2e test. If working locally with migration test it should point to older version of amplify. Absolute paths are recommended.
| @@ -44,10 +44,12 @@ export const amplifyPush = async (cwd: string, testingWithLatestCodebase = false | |||
| const pushArgs = ['push', ...(opts?.minify ? ['--minify'] : [])]; | |||
| // Test amplify push | |||
| await spawn(getCLIPath(testingWithLatestCodebase), pushArgs, { cwd, stripColors: true, noOutputTimeout: pushTimeoutMS }) | |||
| .wait('Are you sure you want to continue?') | |||
| .wait('Are you sure you want to continue "amplify push"?') | |||
There was a problem hiding this comment.
is this correct change?
If e2e tests pass then it's fine I guess.
Otherwise the wait argument can be subset of prompt for example Are you sure you want to continue.
There was a problem hiding this comment.
Oops, I accidentally commit this change..
There was a problem hiding this comment.
Since it passed the e2e test and it's sort of useful, I'll just leave it here
There was a problem hiding this comment.
all e2e tests? if pipeline is green good to keep this.
There was a problem hiding this comment.
Not all e2e tests tho 🫢
Ok...
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah.
if you want to capture both variants then either
.wait('Are you sure you want to continue')
OR .wait(/<some awesome regex to capture both/)
see
There was a problem hiding this comment.
(not sure if we have 2 variants)
There was a problem hiding this comment.
To make it simple, I just removed the change 😂 4ad7631
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #13010 +/- ##
===========================================
+ Coverage 0.00% 48.38% +48.38%
===========================================
Files 1296 840 -456
Lines 149743 38069 -111674
Branches 1296 7787 +6491
===========================================
+ Hits 0 18419 +18419
+ Misses 148447 18056 -130391
- Partials 1296 1594 +298
... and 1237 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
No longer needed. |
Description of changes
Issue: Local e2e test for hanging
sendYeswhenamplify_pushError message:
Ywas sent, but no return.Short term fix: add
.sendCarriageReturn()Long term fix: migrate from
enquirer(npm), which is no longer under maintained. (We implementedenquirerin #7774 because it's lighter thaninquirer(npm) and has some list filtering feature we wanted).Other changes:
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.