feat(Liveness): Add option to use H264 and VP9 codecs. #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing on multiple devices revealed that WebM has better support on older devices.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 37.44% 36.99% -0.46%
==========================================
Files 122 122
Lines 4930 4890 -40
Branches 678 685 +7
==========================================
- Hits 1846 1809 -37
+ Misses 2902 2893 -9
- Partials 182 188 +6 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #288
Description of changes:
This PR adds an option to configure Liveness to use H264 codec (with a MP4 container) or VP9 (with WebM) in addition to the existing default of VP8 + WebM.
The purpose of this change is to enable an alternative to VP8, which is known to have issues encoding on certain Android devices. With this change customers can opt-in to using H264 instead on devices that are having issues with VP8.
We will work to augment this feature with codec auto-selection in a future release.
How did you test these changes?
Verified new codecs work on all the test devices we have.
Documentation update required?
General Checklist
fix(liveness): message,fix(authenticator): message,fix(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.