Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 18 commits
- 59 files changed
- 5 contributors
Commits on Jan 3, 2025
-
Ensure resource is managed before deleting (#165)
Issue [#2102](aws-controllers-k8s/community#2102) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Commits on Jan 23, 2025
-
Bump golang.org/x/net to v0.33.0 (#168)
Bump golang.org/x/net to v0.33.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Commits on Feb 4, 2025
-
* Initial iteration of AWS SDK GO V2 by michaelhtm * Add region to GetCallerIdentity request, handle AwsErrors with APIError * Address PR comments * Fix how we inject user Agent Now using a custom client to inject the user agent
Commits on Feb 17, 2025
-
feat(tags): filter AWS tags and ACK tags during reconciliation (#170)
* feat(tags): add SyncAWSTags for AWS-managed tag preservation Add utility to automatically preserve immutable AWS-managed tags (aws:*) when modifying resources. Prevents tag operation errors with CloudFormation and Service Catalog managed resources. * Add FilterAWSTags as a method in AWSResourceManager interface. This funtion will filter out tags injected by AWS and ACK.
Commits on Mar 25, 2025
-
feat: dependency updates across the board
It's that time of the year... updating all our dependencies! refresh dependencies: - k8s libraries from v0.31.0 to v0.32 - controller-runtime from v0.19.0 to v0.20.4 - Mockery from v2.33.2 to v2.53.3 - Various other dependencies to their latest compatible versions
Commits on Mar 26, 2025
-
feat: dependency updates across the board: Merge pull request #173 fr…
…om a-hilaly/deps feat: dependency updates across the board
Commits on Apr 25, 2025
-
The changes handle the addition of a new adoption-policy called adopt-or-create. The adopt-or-create policy requires users to define the Spec fields in the resource Spec, and the Status fields in the adoption-fields annotation. Requiring the Spec fields be in Spec for adopt-or-create ensures that the users provide fields that may also be required for a create operation. Here is the controller lifecycle of adopt-or-create policy: Controller looks for resource in AWS If found check if there are any differences between user resource definition (desired) and resource definition in AWS (latest). Update if there are any differences If not Found create the resource Unlike the adopt adoption policy, if a resource has adopt-or-create policy and read-only, and it is not found in AWS, the controller will mark that resource with a terminal error.
Commits on Apr 29, 2025
-
update: Update the
Resource already existscondition reason (#177)Description of changes: Currently the condition reason for the `Resource Already Exists` condition message instructs users to adopt the existing resource using the `AdoptResource` CRD, which we no longer implement. This change updates the message to instruct users to instead use the adoption by annotation feature to import an existing resource. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Commits on May 6, 2025
-
add
reconcile-reourcesflag (#176)The AWS Controllers for Kubernetes (ACK) service controllers currently initialize reconcilers for all supported resource kinds, regardless of operational needs, leading to unnecessary resource consumption and potential for conflicts. We propose introducing a --reconcile-resources flag that allows operators to specify which resource kinds should be actively reconciled, enabling more efficient resource utilization and operational control. When provided with a comma-separated list of resource kinds (e.g., "Queue,Topic"), the controller will only create reconcilers for those specific resources. This enhancement maintains backward compatibility by continuing to reconcile all resources when the flag is not specified.
-
fix: ensure Status fields are populated! (#181)
Issue [#2459](aws-controllers-k8s/community#2459) Description of changes: When we have adopt-or-create, the populated status was not getting patched to k8s. So, during the next reconcile, the controller attempts to recreate the resource. With this fix, we ensure that the controller does patch the resource with the adoption field! By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Commits on May 12, 2025
-
fix: mark resource as adopted (#182)
Issue #, if available: Description of changes: Ensure resource is marked as adopted after successful adoption By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
-
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Commits on Jun 3, 2025
-
Bump golang.org/x/net from 0.37.0 to 0.38.0 (#189)
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.37.0 to 0.38.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9"><code>e1fcd82</code></a> html: properly handle trailing solidus in unquoted attribute value in foreign...</li> <li><a href="https://github.com/golang/net/commit/ebed060e8f30f20235f74808c22125fd86b15edd"><code>ebed060</code></a> internal/http3: fix build of tests with GOEXPERIMENT=nosynctest</li> <li><a href="https://github.com/golang/net/commit/1f1fa29e0a46fffe18c43a9da8daa5a0b180dfa9"><code>1f1fa29</code></a> publicsuffix: regenerate table</li> <li><a href="https://github.com/golang/net/commit/12150816f701c912a32a376754ab28dd3878833a"><code>1215081</code></a> http2: improve error when server sends HTTP/1</li> <li><a href="https://github.com/golang/net/commit/312450e473eae9f9e6173ad895c80bc5ea2f79ad"><code>312450e</code></a> html: ensure <search> tag closes <p> and update tests</li> <li><a href="https://github.com/golang/net/commit/09731f9bf919b00b344c763894cd1920b3d96d90"><code>09731f9</code></a> http2: improve handling of lost PING in Server</li> <li><a href="https://github.com/golang/net/commit/55989e24b972a90ab99308fdc7ea1fb58a96fef1"><code>55989e2</code></a> http2/h2c: use ResponseController for hijacking connections</li> <li><a href="https://github.com/golang/net/commit/2914f46773171f4fa13e276df1135bafef677801"><code>2914f46</code></a> websocket: re-recommend gorilla/websocket</li> <li>See full diff in <a href="https://github.com/golang/net/compare/v0.37.0...v0.38.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/aws-controllers-k8s/runtime/network/alerts). </details>
Commits on Jun 11, 2025
-
Fix controller shutdown status patching with a fresh context for patc…
…hes (#191) Fixes: aws-controllers-k8s/community#2497, aws-controllers-k8s/community#2103 **Description of changes:** During controller shutdown (SIGTERM), status updates were failing because `patchResourceStatus` was attempting to patch using the original cancelled context. This resulted in resources not having their final status properly updated in the resource manifest, leaving them in an inconsistent state. **FIX**: Always use `context.WithoutCancel(ctx)` for all patch operations to prevent cancellation propagation while preserving context values. The 30s SIGTERM grace period serves as the effective timeout, eliminating the need for additional timeout logic that could interfere with normal Kubernetes client timeout/retry strategy. **Changes:** Created util functions: ``` - patchWithoutCancel() - patchStatusWithoutCancel() ``` **Operations updated to Use` context.WithoutCancel(ctx)`** Main Reconciler: ``` - patchResourceMetadataAndSpec() - patchResourceStatus() ``` Adoption Reconciler: ``` - patchMetadataAndSpec() - patchStatus() ``` Field Export Reconciler: ``` - patchMetadataAndSpec() - patchStatus() - writeToConfigMap() - writeToSecret() ``` eg logs: ``` {"level":"debug","ts":"2025-06-05T09:52:16.723-0700","logger":"ackrt","msg":"< r.Sync","kind":"Policy","namespace":"default","name":"iiobalic90","account":"xx","role":"","region":"us-west-2","is_adopted":false,"generation":1,"error":"operation error IAM: GetPolicy, context canceled"} {"level":"info","ts":"2025-06-05T09:52:16.723-0700","logger":"ackrt","msg":"created patch context with timeout","kind":"Policy","namespace":"default","name":"iiobalic90","account":"xx","role":"","region":"us-west-2","is_adopted":false,"generation":1,"timeout_seconds":10} {"level":"debug","ts":"2025-06-05T09:52:16.723-0700","logger":"ackrt","msg":"> r.patchResourceStatus","kind":"Policy","namespace":"default","name":"iiobalic90","account":"xx","role":"","region":"us-west-2","is_adopted":false,"generation":1} ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Commits on Jun 16, 2025
-
fix: Ensure feature gates are enabled for unit tests (#187)
Description of changes: Extra changes: * Ensure lateInitialize is not called for readOnly policy * Add mock call for PopulateResourceFromAnnotation in adopt tests * Ensure FilterSystemTags is called for `adopt` policy By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Commits on Jun 18, 2025
-
fix: Remove Finalizer from resource if create returns error (#185)
Issue [#2406#issuecomment-2860631351](aws-controllers-k8s/community#2406 (comment)) Description of changes: The reason marking a resource as managed (putting the finalizer) before attempting a create is a general practice in kubernetes. The main reason we do it is to protect against deletion protection. If we don't put the finalizer, there is no deletion protection against the resource. The current adoption logic expects the resource to not be managed (no finalizer) to trigger an adoption. If the initial creation attempt of a resource fails due to any AWS error, any subsequent reconciliations attempting to adopt an existing resource will not succeed. These changes set the resource as unmanaged if for any reason there is an error during the create call, which will allow the adoption logic to run in subsequent reconciliations. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Commits on Jun 20, 2025
-
fix: ensure we mark resource as adopted adopt-or-create (#186)
Issue [#2459#issuecomment-2879691276](aws-controllers-k8s/community#2459 (comment)) Description of changes: Currently the `adopted` annotation was getting removed when the resource goes through update path during adopt-or-create adoption. These changes ensure the annotation is persisted in k8s. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.