Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Clean up POMs #1463

Open
1 of 2 tasks
scottgerring opened this issue Oct 10, 2023 · 0 comments · Fixed by #1535
Open
1 of 2 tasks

Maintenance: Clean up POMs #1463

scottgerring opened this issue Oct 10, 2023 · 0 comments · Fixed by #1535
Assignees
Labels
good first issue Good for newcomers priority:3 Neutral - not a core feature or affects less than 40% of users v2 Version 2
Milestone

Comments

@scottgerring
Copy link
Contributor

Summary

There is a lot of information duplicated between all of our POMs that can likely be kept in the parent POM only. We should take the v2 release as an opportunity to clean it up. Using powertools-core as an example, this all seems unnecessary:

<url>https://aws.amazon.com/lambda/</url>
<issueManagement>
<system>GitHub Issues</system>
<url>https://github.com/aws-powertools/powertools-lambda-java/issues</url>
</issueManagement>
<scm>
<url>https://github.com/aws-powertools/powertools-lambda-java.git</url>
</scm>
<developers>
<developer>
<name>Powertools for AWS Lambda team</name>
<organization>Amazon Web Services</organization>
<organizationUrl>https://aws.amazon.com/</organizationUrl>
</developer>
</developers>
<distributionManagement>
<snapshotRepository>
<id>ossrh</id>
<url>https://aws.oss.sonatype.org/content/repositories/snapshots</url>
</snapshotRepository>
</distributionManagement>

If we have a look at the powertools-batch POM, we can see that it's working fine without any of this, as its all in the parent anyway.

Why is this needed?

As we added more projects (examples, modules broken down into smaller components), the amount of repetition in the POMs themselves is becoming increasingly error-prone.

Which area does this relate to?

Governance

Solution

No response

Acknowledgment

@scottgerring scottgerring added v2 Version 2 priority:3 Neutral - not a core feature or affects less than 40% of users good first issue Good for newcomers labels Oct 10, 2023
@jdoherty jdoherty self-assigned this Dec 1, 2023
@jdoherty jdoherty linked a pull request Dec 4, 2023 that will close this issue
6 tasks
@scottgerring scottgerring added this to the v2 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority:3 Neutral - not a core feature or affects less than 40% of users v2 Version 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants