Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: V2 updates - review interface & propose improvements for Tracing module #1468

Open
1 of 2 tasks
scottgerring opened this issue Oct 10, 2023 · 3 comments
Open
1 of 2 tasks
Labels
maintenance priority:2 High - core feature or affects 60% of the users v2 Version 2
Milestone

Comments

@scottgerring
Copy link
Contributor

Summary

We should use the V2 release as an opportunity to reflect upon the interfaces of our existing modules and identify areas of improvement. This work has been done as part of rewrites for some modules, and in isolation for others - check out #1283 for details.

Why is this needed?

  • Minimize the likelihood that we need to make more breaking changes to PT-Java again soon in the future
  • Double-down on the quality of the project by forcing large-scale code review
  • Increase knowledge of the modules around the contributor team

Which area does this relate to?

No response

Solution

  1. A review of the current module, its public interface and structure, and potential areas for improvement documented on this ticket for discussion
  2. A draft PR against the v2 branch showing the high level impact of proposed changes
  3. PR completed and merged into v2

Acknowledgment

@scottgerring scottgerring added maintenance v2 Version 2 priority:2 High - core feature or affects 60% of the users labels Oct 10, 2023
@AlexeySoshin
Copy link
Contributor

Happy to take a look at this!

@scottgerring
Copy link
Contributor Author

@heitorlessa - what do you think about this - do you have a view on whether or not all languages should be going modular with regards to the tracing providers like python has?

@scottgerring scottgerring added this to the v2 milestone Dec 21, 2023
@scottgerring
Copy link
Contributor Author

I noticed that the way we are including tracing at the moment pulls in bits of the V1 AWS SDK. We should definitely fix that while we are here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance priority:2 High - core feature or affects 60% of the users v2 Version 2
Projects
Status: Backlog
Development

No branches or pull requests

2 participants