Skip to content

Commit fa711f8

Browse files
committed
update mocked grpc wrapper
add new lines to satisfy format check update unit tests for DialContext
1 parent 0d5bd6d commit fa711f8

File tree

4 files changed

+32
-24
lines changed

4 files changed

+32
-24
lines changed

Diff for: cmd/routed-eni-cni-plugin/cni.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import (
3232
"golang.org/x/net/context"
3333
"google.golang.org/grpc"
3434
"google.golang.org/grpc/credentials/insecure"
35-
35+
3636
"github.com/aws/amazon-vpc-cni-k8s/cmd/routed-eni-cni-plugin/driver"
3737
"github.com/aws/amazon-vpc-cni-k8s/pkg/grpcwrapper"
3838
"github.com/aws/amazon-vpc-cni-k8s/pkg/ipamd/datastore"

Diff for: cmd/routed-eni-cni-plugin/cni_test.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@ func TestCmdAdd(t *testing.T) {
9595
mocksRPC.EXPECT().NewCNIBackendClient(conn).Return(mockC)
9696

9797
npConn, _ := grpc.Dial(npAgentAddress, grpc.WithInsecure())
98+
mocksGRPC.EXPECT().DialContext(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(npConn, nil).Times(1)
9899

99-
mocksGRPC.EXPECT().Dial(gomock.Any(), gomock.Any()).Return(npConn, nil)
100100
mockNP := mock_rpc.NewMockNPBackendClient(ctrl)
101-
mocksRPC.EXPECT().NewNPBackendClient(npConn).Return(mockNP)
101+
mocksRPC.EXPECT().NewNPBackendClient(npConn).Return(mockNP).Times(1)
102102

103103
enforceNpReply := &rpc.EnforceNpReply{Success: true}
104-
mockNP.EXPECT().EnforceNpToPod(gomock.Any(), gomock.Any()).Return(enforceNpReply, nil)
104+
mockNP.EXPECT().EnforceNpToPod(gomock.Any(), gomock.Any()).Return(enforceNpReply, nil).Times(1)
105105

106106
addNetworkReply := &rpc.AddNetworkReply{Success: true, IPv4Addr: ipAddr, DeviceNumber: devNum, NetworkPolicyMode: "none"}
107107
mockC.EXPECT().AddNetwork(gomock.Any(), gomock.Any()).Return(addNetworkReply, nil)
@@ -113,7 +113,7 @@ func TestCmdAdd(t *testing.T) {
113113
mocksNetwork.EXPECT().SetupPodNetwork(gomock.Any(), cmdArgs.IfName, cmdArgs.Netns,
114114
v4Addr, nil, int(addNetworkReply.DeviceNumber), gomock.Any(), gomock.Any()).Return(nil)
115115

116-
mocksTypes.EXPECT().PrintResult(gomock.Any(), gomock.Any()).Return(nil)
116+
mocksTypes.EXPECT().PrintResult(gomock.Any(), gomock.Any()).Return(nil).Times(1)
117117

118118
err := add(cmdArgs, mocksTypes, mocksGRPC, mocksRPC, mocksNetwork)
119119
assert.Nil(t, err)
@@ -140,7 +140,7 @@ func TestCmdAddWithNPenabled(t *testing.T) {
140140

141141
npConn, _ := grpc.Dial(npAgentAddress, grpc.WithInsecure())
142142

143-
mocksGRPC.EXPECT().Dial(gomock.Any(), gomock.Any()).Return(npConn, nil)
143+
mocksGRPC.EXPECT().DialContext(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(npConn, nil).Times(1)
144144
mockNP := mock_rpc.NewMockNPBackendClient(ctrl)
145145
mocksRPC.EXPECT().NewNPBackendClient(npConn).Return(mockNP)
146146

@@ -184,7 +184,7 @@ func TestCmdAddWithNPenabledWithErr(t *testing.T) {
184184

185185
npConn, _ := grpc.Dial(npAgentAddress, grpc.WithInsecure())
186186

187-
mocksGRPC.EXPECT().Dial(gomock.Any(), gomock.Any()).Return(npConn, nil)
187+
mocksGRPC.EXPECT().DialContext(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(npConn, nil).Times(1)
188188
mockNP := mock_rpc.NewMockNPBackendClient(ctrl)
189189
mocksRPC.EXPECT().NewNPBackendClient(npConn).Return(mockNP)
190190

@@ -292,7 +292,7 @@ func TestCmdDel(t *testing.T) {
292292

293293
npConn, _ := grpc.Dial(npAgentAddress, grpc.WithInsecure())
294294

295-
mocksGRPC.EXPECT().Dial(gomock.Any(), gomock.Any()).Return(npConn, nil)
295+
mocksGRPC.EXPECT().DialContext(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(npConn, nil).Times(1)
296296
mockNP := mock_rpc.NewMockNPBackendClient(ctrl)
297297
mocksRPC.EXPECT().NewNPBackendClient(npConn).Return(mockNP)
298298

@@ -396,7 +396,7 @@ func TestCmdAddForPodENINetwork(t *testing.T) {
396396

397397
npConn, _ := grpc.Dial(npAgentAddress, grpc.WithInsecure())
398398

399-
mocksGRPC.EXPECT().Dial(gomock.Any(), gomock.Any()).Return(npConn, nil)
399+
mocksGRPC.EXPECT().DialContext(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(npConn, nil).Times(1)
400400
mockNP := mock_rpc.NewMockNPBackendClient(ctrl)
401401
mocksRPC.EXPECT().NewNPBackendClient(npConn).Return(mockNP)
402402

@@ -442,7 +442,7 @@ func TestCmdDelForPodENINetwork(t *testing.T) {
442442

443443
npConn, _ := grpc.Dial(npAgentAddress, grpc.WithInsecure())
444444

445-
mocksGRPC.EXPECT().Dial(gomock.Any(), gomock.Any()).Return(npConn, nil)
445+
mocksGRPC.EXPECT().DialContext(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(npConn, nil).Times(1)
446446
mockNP := mock_rpc.NewMockNPBackendClient(ctrl)
447447
mocksRPC.EXPECT().NewNPBackendClient(npConn).Return(mockNP)
448448

Diff for: pkg/grpcwrapper/client.go

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ package grpcwrapper
1616

1717
import (
1818
"context"
19+
1920
google_grpc "google.golang.org/grpc"
2021
)
2122

Diff for: pkg/grpcwrapper/mocks/grpcwrapper_mocks.go

+21-14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)