-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-event-sources): starting position timestamp for kafka #31439
base: main
Are you sure you want to change the base?
feat(lambda-event-sources): starting position timestamp for kafka #31439
Conversation
could you please add a new GH issue as a Feature request, and link it to this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this is a feature and not a chore, and it needs update in Readme, and new integration test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @moelasmar, this seems like a feat to me - @nikovirtala can you please add an integ test and README documentation on this?
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
e521983
to
ab944c3
Compare
README is clear, but creating the integration test for this is a lot of work:
|
Ok, the MSK module is in alpha state, and even that doesn't have an integration test that would create a topic and messages to the topic — which would be required to test this feature 😞 I doubt that creating all that is too much for me. |
811d9b7
to
81e290b
Compare
81e290b
to
19100c2
Compare
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31439 +/- ##
=======================================
Coverage 77.19% 77.19%
=======================================
Files 105 105
Lines 7164 7164
Branches 1311 1311
=======================================
Hits 5530 5530
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #31808
Reason for this change
It was impossible to start consuming a Kafka topic from a specific point in time.
Description of changes
The user may now set
startingPositionTimestamp
toManagedKafkaEventSource
andSelfManagedKafkaEventSource
to start consuming a Kafka topic from a specific point in time.Lambda and CloudFormation have supported the functionality for a while, and other stream event sources like
KinesisEventSource
already had a CDK implementation for it, so there's nothing new under the sky — just expanding it to cover sources we are using :)Description of how you validated changes
The change is tested by adding similar unit tests to other event sources supporting this functionality.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license