-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(glue): timeout and worker type validation for Ray jobs #32119
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32119 +/- ##
=======================================
Coverage 77.29% 77.29%
=======================================
Files 114 114
Lines 7627 7627
Branches 1360 1360
=======================================
Hits 5895 5895
Misses 1550 1550
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
However, this fix will not be reflected once #30833 is merged.
I'll leave the decision on how to proceed to the maintainers.
Issue # (if applicable)
Closes #29612.
Reason for this change
AWS Glue Ray job has some restriction.
Description of changes
Add validation for above restriction.
Description of how you validated changes
Add unit test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license