Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-cdk/aws-glue-alpha: pythonShell should not require glueVersion #32148

Open
1 task
urkle opened this issue Nov 15, 2024 · 0 comments
Open
1 task

@aws-cdk/aws-glue-alpha: pythonShell should not require glueVersion #32148

urkle opened this issue Nov 15, 2024 · 0 comments
Assignees
Labels
@aws-cdk/aws-glue Related to AWS Glue bug This issue is a bug. needs-reproduction This issue needs reproduction. p2

Comments

@urkle
Copy link

urkle commented Nov 15, 2024

Describe the bug

When creating a pythongshell job type the GlueVersion should not be required (as it is not used for this mode).

All examples of creating python shell jobs do not specify the GlueVersion at all, just the python version

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

I should be able to omit the glueVersion parameter to JobExecution.pythonShell.

Current Behavior

It throws an error stating that the glue_version parameter is required.

Reproduction Steps

glue.Job(
self, 'ShellJob',
job_name='myShellJob',
role=glue_role,
default_arguments={
"--additional-python-modules": "awswrangler,fastparquet,google-api-python-client,google-auth-oauthlib,google-auth-httplib2",
},
timeout=Duration.minutes(30),
max_concurrent_runs=1,
executable=glue.JobExecutable.python_shell(
python_version=glue.PythonVersion.THREE_NINE,
script=glue.Code.from_asset(glue_script_path('my-shell-job.py')),
)
)

Possible Solution

make it optional for PythonShellExecutableProps

Additional Information/Context

No response

CDK CLI Version

2.166.0

Framework Version

No response

Node.js Version

18.16.1

OS

macOS 12.7.6

Language

Python

Language Version

3.9

Other information

@aws-cdk/aws-glue-alpha = 2.166.0a0

@urkle urkle added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label Nov 15, 2024
@khushail khushail added needs-reproduction This issue needs reproduction. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 15, 2024
@khushail khushail self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue bug This issue is a bug. needs-reproduction This issue needs reproduction. p2
Projects
None yet
Development

No branches or pull requests

2 participants