Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should images ship with docker-credential-ecr-login pre-installed and configured? #743

Open
moltar opened this issue Sep 25, 2024 · 2 comments · May be fixed by #745
Open

Should images ship with docker-credential-ecr-login pre-installed and configured? #743

moltar opened this issue Sep 25, 2024 · 2 comments · May be fixed by #745

Comments

@moltar
Copy link

moltar commented Sep 25, 2024 •
edited
Loading

https://github.com/awslabs/amazon-ecr-credential-helper

It seems like a massive improvement over the classic:

aws ecr get-login-password --region=foo | \
  docker login --username AWS --password-stdin repository-uri
@jplock
Copy link

jplock commented Oct 3, 2024

It looks like the package is already included but needs to be configured.

@moltar
Copy link
Author

moltar commented Oct 3, 2024 •
edited
Loading

Hm, that's interesting because I don't see it on the aws/codebuild/standard:7.0 image:

#2 ERROR: error getting credentials - err: exec: "docker-credential-ecr-login": executable file not found in $PATH, out: ``

@moltar moltar mentioned this issue Oct 3, 2024
Open
2 tasks
@jplock jplock linked a pull request Oct 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feat] Install and configure ECR credential helper jplock/aws-codebuild-docker-images
2 participants
@jplock @moltar