Skip to content

Commit a2417b5

Browse files
committed
chore: cleanup comments and minor spelling
1 parent cfa8af9 commit a2417b5

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

source/packages/services/certificatevendor/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ The private CA needs to be registered with AWS IoT. The example registration ste
5353
$ aws iot register-ca-certificate --ca-certificate file://Certificate.pem --verification-certificate file://Verify.crt --region ap-northeast-1 --set-as-active
5454
```
5555

56-
The registered CA Certificate ID and PCA Authority Arn needs to be inputted
57-
in the in the inquiry prompt in the installer, or request body as parameters.
56+
The registered CA Certificate ID and PCA Authority Arn need to be entered
57+
in the inquiry prompt in the installer or request body as parameters.
5858

5959
## Deployment
6060

source/packages/services/installer/src/commands/modules/service/certificateVendor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export class CertificateVendorInstaller implements ServiceModule {
104104
askAnswered: true,
105105
validate: (answer: string) => {
106106
if (answer?.length === 0) {
107-
return true; // TODO: should this be false?
107+
return true;
108108
}
109109
return CommonArnValidations.validateAwsIAMRoleArn(answer);
110110
},

source/packages/services/installer/src/utils/common-arn-validations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export function validateAcmPcaArn(arn: string): boolean | string {
99
export function validateAwsIotCaID(arn: string): boolean | string {
1010
return /^[A-Za-z0-9]+(?:[A-Za-z0-9]+)+$/.test(arn)
1111
? true
12-
: 'Value is not a valid AWS IoT CA Arn';
12+
: 'Value is not a valid AWS IoT CA ID';
1313
}
1414

1515
export function validateAwsIAMRoleArn(arn: string): boolean | string {

0 commit comments

Comments
 (0)