other fixes

Author: smittals2

crypto/bio/bio.c

@@ -85,11 +85,15 @@ static int call_bio_callback_with_processed(BIO *bio, const int oper,
     // Pass the original BIO's return value to the callback. If the callback
     // is successful return processed from the callback, if the callback is
     // not successful return the callback's return value.
-    ret = (int)bio->callback_ex(bio, oper, buf, len, 0, 0L, ret, &processed);
-    if (ret > 0) {
-      // BIO will only read int |len| bytes so this is a safe cast
-      ret = (int)processed;
+    long callback_ret = bio->callback_ex(bio, oper, buf, len, 0, 0L, ret, &processed);
+    if (callback_ret <= INT_MAX) {
+      ret = (int)callback_ret;
+      if (ret > 0) {
+        // BIO will only read int |len| bytes so this is a safe cast
+        ret = (int)processed;
+      }
     }
+
   }
   return ret;
 }
@@ -131,9 +135,9 @@ int BIO_free(BIO *bio) {
       bio->method->destroy(bio);
     }
     if (HAS_CALLBACK(bio)) {
-      int ret = (int)bio->callback_ex(bio, BIO_CB_FREE, NULL, 0, 0, 0L, 1L, NULL);
-      if (ret <= 0) {
-        return ret;
+      long ret = bio->callback_ex(bio, BIO_CB_FREE, NULL, 0, 0, 0L, 1L, NULL);
+      if (ret <= 0 && ret >= INT_MIN) {
+        return (int)ret;
       }
     }
 
@@ -167,9 +171,9 @@ int BIO_read(BIO *bio, void *buf, int len) {
   }
 
   if (HAS_CALLBACK(bio)) {
-    ret = (int)bio->callback_ex(bio, BIO_CB_READ, buf, len, 0, 0L, 1L, NULL);
-    if (ret <= 0) {
-      return ret;
+    long callback_ret = bio->callback_ex(bio, BIO_CB_READ, buf, len, 0, 0L, 1L, NULL);
+    if (callback_ret <= 0 && callback_ret >= INT_MIN) {
+      return (int)callback_ret;
     }
   }
   if (!bio->init) {
@@ -217,18 +221,17 @@ int BIO_gets(BIO *bio, char *buf, int len) {
     return 0;
   }
 
-  int ret = 0;
   if (HAS_CALLBACK(bio)) {
-    ret = (int)bio->callback_ex(bio, BIO_CB_GETS, buf, len, 0, 0L, 1L, NULL);
-    if (ret <= 0) {
-      return ret;
+    long callback_ret = bio->callback_ex(bio, BIO_CB_GETS, buf, len, 0, 0L, 1L, NULL);
+    if (callback_ret <= 0 && callback_ret >= INT_MIN) {
+      return (int)callback_ret;
     }
   }
   if (!bio->init) {
     OPENSSL_PUT_ERROR(BIO, BIO_R_UNINITIALIZED);
     return -2;
   }
-  ret = bio->method->bgets(bio, buf, len);
+  int ret = bio->method->bgets(bio, buf, len);
   if (ret > 0) {
     bio->num_read += ret;
   }
@@ -248,9 +251,9 @@ int BIO_write(BIO *bio, const void *in, int inl) {
   }
 
   if (HAS_CALLBACK(bio)) {
-    ret = (int)bio->callback_ex(bio, BIO_CB_WRITE, in, inl, 0, 0L, 1L, NULL);
-    if (ret <= 0) {
-      return ret;
+    long callback_ret = bio->callback_ex(bio, BIO_CB_WRITE, in, inl, 0, 0L, 1L, NULL);
+    if (callback_ret <= 0 && callback_ret >= INT_MIN) {
+      return (int)callback_ret;
     }
   }
 
@@ -317,18 +320,18 @@ int BIO_puts(BIO *bio, const char *in) {
     OPENSSL_PUT_ERROR(BIO, BIO_R_UNSUPPORTED_METHOD);
     return -2;
   }
-  int ret = 0;
   if(HAS_CALLBACK(bio)) {
-    ret = (int)bio->callback_ex(bio, BIO_CB_PUTS, in, 0, 0, 0L, 1L, NULL);
-    if (ret <= 0) {
-      return ret;
+    long callback_ret = bio->callback_ex(bio, BIO_CB_PUTS, in, 0, 0, 0L, 1L, NULL);
+    if (callback_ret <= 0 && callback_ret >= INT_MIN) {
+      return (int)callback_ret;
     }
   }
 
   if (!bio->init) {
     OPENSSL_PUT_ERROR(BIO, BIO_R_UNINITIALIZED);
     return -2;
   }
+  int ret = 0;
   if (bio->method->bputs != NULL) {
     ret = bio->method->bputs(bio, in);
   } else {

crypto/bio/hexdump.c

@@ -98,7 +98,9 @@ static int hexdump_write(struct hexdump_ctx *ctx, const uint8_t *data,
   for (size_t i = 0; i < len; i++) {
     if (ctx->used == 0) {
       // The beginning of a line.
-      BIO_indent(ctx->bio, ctx->indent, UINT_MAX);
+      if (!BIO_indent(ctx->bio, ctx->indent, UINT_MAX)) {
+        return 0;
+      }
 
       hexbyte(&buf[0], ctx->n >> 24);
       hexbyte(&buf[2], ctx->n >> 16);

crypto/bn_extra/convert.c

@@ -448,7 +448,7 @@ BIGNUM *BN_mpi2bn(const uint8_t *in, size_t len, BIGNUM *out) {
   }
   out->neg = ((*in) & 0x80) != 0;
   if (out->neg) {
-    BN_clear_bit(out, BN_num_bits(out) - 1);
+    BN_clear_bit(out, (int)BN_num_bits(out) - 1);
   }
   return out;
 }

crypto/evp_extra/evp_test.cc

@@ -584,7 +584,8 @@ static bool TestEVP(FileTest *t, KeyMap *key_map) {
       return false;
     }
     actual.resize(len);
-    VerifyEVPSignOut(key_name, input, actual, output, ctx.get(), len);
+    VerifyEVPSignOut(key_name, std::move(input), std::move(actual),
+      std::move(output), ctx.get(), len);
     return true;
   }
 

crypto/fipsmodule/modes/cbc.c

@@ -85,12 +85,10 @@ void CRYPTO_cbc128_encrypt(const uint8_t *in, uint8_t *out, size_t len,
     }
     (*block)(out, out, key);
     iv = out;
+    // This will always be true as a result of the first while loop
     if (len <= 16) {
       break;
     }
-    len -= 16;
-    in += 16;
-    out += 16;
   }
 
   OPENSSL_memcpy(ivec, iv, 16);

crypto/pkcs7/bio/bio_md_test.cc

@@ -183,7 +183,7 @@ TEST_P(BIOMessageDigestTest, Randomized) {
   };
   std::vector<size_t> v(1000);
   std::generate(v.begin(), v.end(), [] { return rand() % MESSAGE_LEN; });
-  io_patterns.push_back(v);
+  io_patterns.push_back(std::move(v));
 
   for (auto io_pattern : io_patterns) {
     message.clear();

ssl/test/test_config.cc

@@ -1081,7 +1081,7 @@ static std::vector<std::string> DecodeHexStrings(
       return ret;
     }
 
-    ret.push_back(binary);
+    ret.push_back(std::move(binary));
   }
 
   return ret;