Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function argument not used #4780

Closed
hozzer opened this issue Mar 30, 2023 · 2 comments
Closed

function argument not used #4780

hozzer opened this issue Mar 30, 2023 · 2 comments
Assignees
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue

Comments

@hozzer
Copy link

hozzer commented Mar 30, 2023

Describe the issue

service/s3/api.go

NewSelectObjectContentEventStream function doc currently contains the following:

es := NewSelectObjectContentEventStream(func(o *SelectObjectContentEventStream){
	es.Reader = myMockStreamReader
	es.StreamCloser = myMockStreamCloser
})

It should be:

es := NewSelectObjectContentEventStream(func(o *SelectObjectContentEventStream){
	o.Reader = myMockStreamReader
	o.StreamCloser = myMockStreamCloser
})

Links

https://pkg.go.dev/github.com/aws/[email protected]/service/s3#NewSelectObjectContentEventStream

@hozzer hozzer added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Mar 30, 2023
@RanVaknin
Copy link
Contributor

Hi @hozzer ,

Thanks for raising the issue. Yes this seems like a typo. We will fix this 👍
Cheers,
Ran~

@RanVaknin RanVaknin self-assigned this Mar 30, 2023
@RanVaknin RanVaknin added needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Mar 30, 2023
@RanVaknin RanVaknin added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-review This issue or pull request needs review from a core team member. labels Jun 1, 2023
@lucix-aws lucix-aws removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Dec 13, 2023
@lucix-aws lucix-aws closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants