Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer TelemetryProvider not included in version catalog #1481

Open
1 task
cloudshiftchris opened this issue Dec 19, 2024 · 0 comments
Open
1 task

Micrometer TelemetryProvider not included in version catalog #1481

cloudshiftchris opened this issue Dec 19, 2024 · 0 comments
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@cloudshiftchris
Copy link

Describe the bug

A Micrometer TelemetryProvider was added in smithy-kotlin via smithy-lang/smithy-kotlin#1087.

This artifact appears to be published on Maven as implementation("aws.smithy.kotlin:telemetry-provider-micrometer-jvm:1.3.30")

However, the generated version catalog does not contain it; for 1.3.89 the version catalog entries for telemetry are:

runtime-smithy-kotlin-telemetry-api = {group = "aws.smithy.kotlin", name = "telemetry-api", version = "1.3.28" }
runtime-smithy-kotlin-telemetry-defaults = {group = "aws.smithy.kotlin", name = "telemetry-defaults", version = "1.3.28" }
runtime-smithy-kotlin-telemetry-provider-otel = {group = "aws.smithy.kotlin", name = "telemetry-provider-otel", version = "1.3.28" }

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected behavior

All published modules (except those that are explicitly excluded) are published in the version catalog.

Current behavior

Micrometer TelemetryProvider is not included in the published version catalog.

Looking at bom/build.gradle.kts for this SDK, and the equivalent file for smithy-kotlin, shows no obvious reason why it isn't included.

Steps to Reproduce

View the published version catalog for the SDK.

Possible Solution

Workaround: explicitly include the maven coordinates for the micrometer telemetry provider artifact

Context

Switching Spring Boot app from OTEL to Micrometer; when attempting to change the SDK clients to use Micrometer telemetry provider discovered it isn't readily available (we import the version catalog to create Gradle type dependency references such as implementation(awssdk.runtime.smithy.kotlin.telemetry.provider)).

Explicitly added implementation("aws.smithy.kotlin:telemetry-provider-micrometer:1.3.28") as a workaround.

AWS SDK for Kotlin version

1.3.89

Platform (JVM/JS/Native)

JVM

Operating system and version

MacOS/Linux/Windows

@cloudshiftchris cloudshiftchris added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

1 participant