admob banner not showing in v2.5.0

[meehjeevan]

I'm trying to update my project from v2.1.5 to v2.5.0.
There admob banner was perfectly working but with same codes it's not working in v2.5.0. Please help me what went wrong?
I can see log for onAdLoaded event but when showBannerAd is called the banner is not being shown.

private static Activity self = null;
public static FrameLayout.LayoutParams layoutParams = new FrameLayout.LayoutParams(
    FrameLayout.LayoutParams.MATCH_PARENT,
    FrameLayout.LayoutParams.WRAP_CONTENT, Gravity.TOP);

protected void onCreate(Bundle savedInstanceState) {
    self = this;
}

this is how loading is done.

private void loadBanner() {
    Log.d(TAG,"loadBanner>start ");

    AxmolEngine.getActivity().runOnUiThread(new Runnable() {
        @Override
        public void run() {
            // Create an ad request.
            bannerAdView = new AdView(AppActivity.self);
            bannerAdView.setAdUnitId(BANNER_AD_UNIT_ID);

            AdSize adSize = getAdSize();
            bannerAdView.setAdSize(adSize);

            // Code to be executed when an ad finishes loading.

            if (bannerAdView.isLoading()) {
                return;
            }

            AdRequest adRequest = new AdRequest.Builder().build();

            // Start loading the ad in the background.
            bannerAdView.loadAd(adRequest);

            bannerAdView.setAdListener(new AdListener() {
                @Override
                public void onAdLoaded() {
                    Log.d(TAG, "banner onAdLoaded");
                    // Code to be executed when an ad finishes loading.
                }

            });
        }
    });
}

This is how showing banner ad is done.

public static void showBannerAd() {
    AxmolEngine.getActivity().runOnUiThread(new Runnable() {
        @Override
        public void run() {
            if (mFrameLayout == null || bannerAdView == null) {
                Log.e("appActivity", "FrameLayout or BannerAdView is null");
                return;
            }

            // Get the current parent of bannerAdView
            ViewGroup parent = (ViewGroup) bannerAdView.getParent();
            if (parent != null) {
                // If bannerAdView is already attached to a parent, remove it from that parent
                parent.removeView(bannerAdView);
            }

            try {
                // Add bannerAdView to mFrameLayout with layoutParams
                mFrameLayout.addView(bannerAdView, layoutParams);
                // Make the banner visible
                bannerAdView.setVisibility(View.VISIBLE);
                // Resume the banner ad (AdMob-specific)
                bannerAdView.resume();
            } catch (Exception e) {
                Log.e("appActivity", "Failed to add banner ad: " + e.getMessage());
            }
        }
    });
    Log.i("appActivity", "showBannerAd");
}

[meehjeevan]

anyone plz? have any one been able to show admob banner ad on v2.5.0 ?

[rh101]

A lot has changed between 2.1.5 and 2.5.0.

Are you able to test 2.2.0, 2.30 etc. to see when the problem started happening? You can then narrow it down to the actual change that caused the issue.

[meehjeevan]

Haven't tested yet in other versions but I added the adView in mFrameLayout, is it not the way to do in v2.5.0?
Where should I add the adView ?

[rh101]

You're unlikely get much direct help with it unless someone else has AdMob integrated with their Axmol project and they come across this thread.

You're in the best position to diagnose this issue with AdMob, and as I mentioned above, if you're certain it worked with 2.1.5, then you have many different things you can try to find out why it isn't working with 2.5.0. Aside from static inspection of the changes between 2,1.5 and 2.5.0, which I don't recommend, since there are a lot of changes, it would be much faster if you simply test your project with a few different versions between 2.1.5 and 2.5, working your way backwards, such as testing 2.4, then 2.3, then 2.21 etc.. It wouldn't take long, and it would be a lot quicker than guessing or waiting for someone else to guide you to a solution.

[meehjeevan]

testing with other versions will let me know if it's working the same way it was working in v2.1.5 or not only. but how will I be able to make it work in latest v2.5.0 ? It's really frustrating.. I just tried adding in instance of FrameLayout instead of mFrameLayout and still it's not working.

[rh101]

testing with other versions will let me know if it's working the same way it was working in v2.1.5 or not only.

That is precisely the point. When you find which version it stopped working at, then it narrows down the possible changes to the code that may have caused the issue.

but how will I be able to make it work in latest v2.5.0

You need to find out the problem first before it can be fixed.

So, once again, you can either keep waiting for someone that has some experience with AdMob to respond, or you can simply test it yourself to find the issue very quickly.