Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cocos2dx/Axmol 1.0.1: Label issues: 1) Underline/Strikethrough can not use on the same label; 2) Resizing the window is not resizing the line (underline/strikethrough) 3) Line color is not Label color #2328

Closed
aismann opened this issue Jan 11, 2025 · 4 comments · Fixed by #2382
Closed

Cocos2dx/Axmol 1.0.1: Label issues: 1) Underline/Strikethrough can not use on the same label; 2) Resizing the window is not resizing the line (underline/strikethrough) 3) Line color is not Label color #2328

aismann opened this issue Jan 11, 2025 · 4 comments · Fixed by #2382
Assignees
@aismann
Labels
Axmol-v1 bug Something isn't working cocos2dx The issue present in original cocos2dx official-v4
Milestone
2.4.0

Comments

@aismann
Copy link
Contributor

aismann commented Jan 11, 2025 •
edited
Loading

  • axmol version >2.0:
    Thickness of the lines be to big.
    image

Should be look like this:
image

Check FairyGUI which using ax:Label too!
@aismann aismann changed the title Thickness issue on Label->enableUnderline(); Label->enableStrikethrough(); Thickness issue on Label->enableUnderline(); Label->enableStrikethrough(); Check also FairyGUI which using ax:Label too! Jan 11, 2025
@aismann aismann self-assigned this Jan 11, 2025
@aismann aismann changed the title Thickness issue on Label->enableUnderline(); Label->enableStrikethrough(); Check also FairyGUI which using ax:Label too! Thickness issue on Label->enableUnderline(); Label->enableStrikethrough(); Check FairyGUI which using ax:Label too! Jan 11, 2025
@aismann
Copy link
Contributor Author

aismann commented Jan 24, 2025 •
edited
Loading

Small update (im still on it):
Size g_resourceSize(960, 640);
Size g_designSize(480, 320);
Image

Image

Image

Size g_resourceSize(960, 640);
Size g_designSize(480, 1320);
Image

@aismann
Copy link
Contributor Author

aismann commented Jan 27, 2025 •
edited
Loading

Some "INTERNAL" info here:
Comparing Axmol 1.0.1p1 (using setLineWidth()) and Axmol "LATEST" (PR have to push!)

Axmol 1.0.1p1: Resizing of the underline is not 'supported':
Image
Image

Axmol 2.3.x: underline is resizing (Fix 2)
Image
Image

Fix also 1) Underline/Strikethrough can not use on the same label;
Image
Image

@aismann aismann added bug Something isn't working Axmol-v1 cocos2dx The issue present in original cocos2dx labels Jan 27, 2025
@aismann aismann changed the title Thickness issue on Label->enableUnderline(); Label->enableStrikethrough(); Check FairyGUI which using ax:Label too! Cocos2dx/Axmol 1.0.1: Label->enableUnderline(); Label->enableStrikethrough(); resizing the window is not resizing the line (underline/strikethrough) Jan 27, 2025
@aismann aismann changed the title Cocos2dx/Axmol 1.0.1: Label->enableUnderline(); Label->enableStrikethrough(); resizing the window is not resizing the line (underline/strikethrough) Cocos2dx/Axmol 1.0.1: Label issues: 1) Underline/Strikethrough can not use on the same label; 2) Resizing the window is not resizing the line (underline/strikethrough) Jan 27, 2025
@aismann
Copy link
Contributor Author

aismann commented Jan 27, 2025

Line color is not Label color:
Image

Fix:
Image

@aismann aismann changed the title Cocos2dx/Axmol 1.0.1: Label issues: 1) Underline/Strikethrough can not use on the same label; 2) Resizing the window is not resizing the line (underline/strikethrough) Cocos2dx/Axmol 1.0.1: Label issues: 1) Underline/Strikethrough can not use on the same label; 2) Resizing the window is not resizing the line (underline/strikethrough) 3) Line color is not Label color Jan 27, 2025
@aismann aismann mentioned this issue Feb 3, 2025
Merged
6 tasks
@aismann
Copy link
Contributor Author

aismann commented Feb 10, 2025

Merged See #2364

@aismann aismann closed this as completed Feb 10, 2025
@halx99 halx99 linked a pull request Feb 10, 2025 that will close this issue
Improve Label underline, strikethrough and color [reverted] #2364
Merged
6 tasks
@halx99 halx99 added this to the 2.3.3 milestone Feb 10, 2025
@halx99 halx99 removed a link to a pull request Feb 10, 2025
Improve Label underline, strikethrough and color [reverted] #2364
Merged
6 tasks
@halx99 halx99 reopened this Feb 10, 2025
@aismann aismann mentioned this issue Feb 10, 2025
Merged
6 tasks
@halx99 halx99 linked a pull request Feb 11, 2025 that will close this issue
Improve Label: underline, strikethrough and color #2382
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aismann aismann

Labels
Axmol-v1 bug Something isn't working cocos2dx The issue present in original cocos2dx official-v4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Improve Label: underline, strikethrough and color aismann/axmol
2 participants
@halx99 @aismann