Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SerializerMethodField + type annotations regression #450

Closed
beaugunderson opened this issue Sep 4, 2019 · 1 comment
Closed

SerializerMethodField + type annotations regression #450

beaugunderson opened this issue Sep 4, 2019 · 1 comment

Comments

@beaugunderson
Copy link
Contributor

We upgraded to 1.16.1 and hit #385 with Optional[int] as well as another issue with List[int], which is previously unreported. Both now resolve to string.

I believe the open PR #428 would fix both issues. :)
@axnsan12
Copy link
Owner

axnsan12 commented Oct 2, 2019

#428 is now merged

@axnsan12 axnsan12 closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beaugunderson @axnsan12