Potential memory leak

[BugBeginner]

In Glib's g_array_free document, it said" The element data if free_segment is FALSE, otherwise NULL. The element data should be freed using g_free(). " So if the second parameter of g_array_free is FALSE, the array's element, i.e., array->data should be freed by g_free.

In lib/file_manager/support.c, line 698, after calling g_array_free(array, FALSE);, it is better to call g_free(array->data)

[ayyi]

Hi thanks for raising this issue.

It looks like the array data is returned as a CollateKey so the caller is responsible for freeing it. This would normally be done by calling collate_key_free.

Its true that this should be better documented, and there should also be a unit test.

If I am missing something, I am happy to be corrected :-)

Regards