Skip to content

Add support for partial module lists #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

andreaswolf
Copy link
Contributor

@andreaswolf andreaswolf commented Feb 19, 2025

This adds support for a partial list of modules in addition to ['*'] for including all modules.

Edit: I included a test, but the workflow does not yet run, so I don't know if it's green. The change works for me locally.

@andreaswolf andreaswolf force-pushed the allow-partial-module-lists branch from c5717f4 to c567787 Compare February 20, 2025 10:58
@achimfritz
Copy link
Contributor

hm, you can already use

modules:
  # enable access to a specific module
  web_list: true
  web_layout: true

for your use case, so i think this change is not required?
(btw.: Tests fails because you write web_page instead of web_layout)

@andreaswolf
Copy link
Contributor Author

andreaswolf commented Feb 26, 2025

hm, you can already use

modules:
  # enable access to a specific module
  web_list: true
  web_layout: true

for your use case, so i think this change is not required?

Yeah, but the code allows ['*'], so I think it's stringent to also allow specifying a list of allowed modules. That is also more in line with e.g. the resource or table permissions or the list of allowed languages.

Maybe it's better then to change the syntax to

modules: ['web_list', 'web_layout']

(leaving out the top-level module keys). What do you think?

(btw.: Tests fails because you write web_page instead of web_layout)

Good catch, will fix that.

@andreaswolf andreaswolf force-pushed the allow-partial-module-lists branch from c567787 to 87d0057 Compare February 26, 2025 08:13
@achimfritz achimfritz merged commit ff82ed1 into b13:main Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants