Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IfcSweptDiskSolidPolygonal changed to IfcNonNegativeLengthMeausure #830

Open
SergejMuhic opened this issue Jun 7, 2024 · 0 comments
Open
Assignees
Labels
EXPRESS Issues or pull requests relating to EXPRESS schema

Comments

@SergejMuhic
Copy link
Collaborator

SergejMuhic commented Jun 7, 2024

          @aothms @TLiebich It seems to me that the `IfcSweptDiskSolidPolygonal` was just changed to `IfcNonNegativeLengthMeausure` and the documentation has not changed. Must have been submitted to ISO like that then.

It's a unification

On this I would have expected the unification to go the other way around honestly. From a more common entity to the one that is less used.

Are there plans on changing the documentation? I was waiting with this PR for that but now I would have to merge for Tunnel Deployment to have a solid baseline.

EDIT: Just remembered that the where rule and 0 filet radius do not fit well together either.

Originally posted by @SergejMuhic in #467 (comment)

The WR does not make sense for FilletRadius=0. The documentation was not updated according to the agreement either.

Also, pinging @aothms all of the renamed attributes are desynched so they did not get documentation from the markdown.

@SergejMuhic SergejMuhic added the EXPRESS Issues or pull requests relating to EXPRESS schema label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EXPRESS Issues or pull requests relating to EXPRESS schema
Projects
Status: TODO
Development

No branches or pull requests

4 participants