Made entity caching only support non binary content.

Author: mtabacman

source/Superluminal-RESTfulAPI-Tests/RESTfulAPIClientTest.class.st

@@ -476,6 +476,26 @@ RESTfulAPIClientTest >> testQueryDoNotStoreResponseInCache [
     withMessageText: 'Cannot complete the request'
 ]
 
+{ #category : 'tests - QUERY' }
+RESTfulAPIClientTest >> testQueryEntityMustBeString [
+
+  self configureHttpClientToRespondWith: ( ( self jsonOkResponseWith: #( 1 2 3 ) )
+        addCachingDirective: 'Max-Age=60';
+        yourself ).
+
+  self
+    should: [
+        apiClient
+          query: ( ZnEntity bytes:
+                ( ByteArray streamContents: [ :out | 32 timesRepeat: [ out nextPut: 255 atRandom ] ] ) )
+          at: self location
+          accepting: 'application/json;version=1.0.0' asMediaType
+          withSuccessfulResponseDo: [ :responseContents | self fail ]
+      ]
+    raise: HTTPClientError badRequest
+    withMessageText: 'Entity to cache can''t be binary'
+]
+
 { #category : 'tests - QUERY' }
 RESTfulAPIClientTest >> testQueryIgnoreETagsWhenDoNotStoreCachingPolicyIsInPlace [
 

source/Superluminal-RESTfulAPI/ExpiringCacheKeyBuilder.class.st

@@ -48,6 +48,9 @@ ExpiringCacheKeyBuilder >> build [
 { #category : 'configuring' }
 ExpiringCacheKeyBuilder >> entity: entity [
 
+  ( entity hasContentType and: [ entity contentType isBinary ] ) ifTrue: [
+      HTTPClientError badRequest signal: 'Entity to cache can''t be binary' ].
+
   entity contents ifNotEmpty: [ :contents | parameters at: #entity put: contents asString ]
 ]