Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments in settings.inc file. #37

Open
izmeez opened this issue Oct 23, 2024 · 3 comments · May be fixed by #38
Open

Update comments in settings.inc file. #37

izmeez opened this issue Oct 23, 2024 · 3 comments · May be fixed by #38
Labels
pr - needs code review The Pull Request needs to be code-reviewed type - documentation Improvements or additions to documentation

Comments

@izmeez
Copy link
Contributor

izmeez commented Oct 23, 2024

This issue is a follow-up to #25

The comments in the settings.inc file need to be updated for Backdrop. PR to follow.
@izmeez izmeez linked a pull request Oct 23, 2024 that will close this issue
Open
@izmeez
Copy link
Contributor Author

izmeez commented Oct 23, 2024

The PR needs review. It includes comment updates for Backdrop, clarity, and phpcs.

@izmeez izmeez added the pr - needs code review The Pull Request needs to be code-reviewed label Oct 23, 2024
@izmeez
Copy link
Contributor Author

izmeez commented Oct 23, 2024

I wonder if the link to the drupal issue queue, https://www.drupal.org/node/1559486, should be a link to the comment adding try and catch, https://www.drupal.org/project/domain/issues/1559486#comment-10188570 that allows the settings.inc file to be included in the settings.php file even before Backdrop is installed. There are other comments in the thread that are no longer relevant.

@yorkshire-pudding yorkshire-pudding added the type - documentation Improvements or additions to documentation label Nov 8, 2024
@stpaultim
Copy link
Member

stpaultim commented Nov 8, 2024 •
edited
Loading

@yorkshire-pudding This PR "Works for me"

Does someone else want to merge it and close this issue.

NOTE: It's late and I did not look super closely at it. But, skimming through it, the changes all seem very sensible and low risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr - needs code review The Pull Request needs to be code-reviewed type - documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated services.inc comments for backdrop, clarity and phpcs. izmeez/domain
3 participants
@stpaultim @izmeez @yorkshire-pudding