Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 error on all Codecov badges #664

Open
bokub opened this issue May 31, 2024 · 4 comments
Open

404 error on all Codecov badges #664

bokub opened this issue May 31, 2024 · 4 comments

Comments

@bokub
Copy link
Contributor

bokub commented May 31, 2024

Hello @amio 👋

It looks like all codecov badges show a 404.... https://badgen.net/codecov

image

@juozasmiskinis
Copy link

Might be related, so I'm posting here. GitLab badges also return 401: https://flat.badgen.net/gitlab

@jdegand
Copy link

jdegand commented Jun 11, 2024

Both gitlab and codecov are not present in the API folder.

@bokub
Copy link
Contributor Author

bokub commented Jun 12, 2024

@jdegand They have been moved to pages/api (#615 & #631)

@bokub bokub changed the title 404 error on all Codecov badges 404 error on all Codecov (and Gitlab) badges Jun 12, 2024
@bokub bokub changed the title 404 error on all Codecov (and Gitlab) badges 404 error on all Codecov badges Jun 12, 2024
@jdegand
Copy link

jdegand commented Jun 12, 2024

@bokub I didn't know that and I made another issue to update the README docs.

The liveBadgeList has gitlab commented out. codecov is also not part of the list.

I tested shields for codecov of babel and it worked. I don't believe the issue is with the codecov endpoint.

I looked into the HTTP requests. Going to https://badgen.net/crates or /codecov seems to send a HTTP request without the params. This first request always returns a 404. That this isn't avoided leads me to believe the http logic could be improved. I also noticed some useEffects being used without dependency arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants