fix(ci): add null to optional arguments

Author: garak

.docker/base/php84/Dockerfile

@@ -0,0 +1,21 @@
+FROM php:8.4-fpm
+
+USER root
+
+# install system packages
+RUN apt-get update \
+    && apt-get -y install git wget \
+    && apt-get install -qqy libzip-dev libpng-dev libjpeg-dev libfreetype6-dev \
+    && apt-get clean; rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* /usr/share/doc/*
+
+# configure php packages
+RUN docker-php-ext-configure gd --with-freetype=/usr/include/ --with-jpeg=/usr/include/
+
+# install php requirements
+RUN docker-php-ext-install zip iconv gd
+
+# install xdebug
+RUN pecl install xdebug \
+    && docker-php-ext-enable xdebug
+
+COPY --from=composer:2.8 /usr/bin/composer /usr/local/bin/composer

.docker/development/php84/Dockerfile

@@ -0,0 +1,5 @@
+FROM pugx/poser:php84
+
+USER root
+
+WORKDIR "/application"

.github/workflows/php.yml

@@ -8,31 +8,33 @@ on:
 
 jobs:
   cs-fix:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     name: PHP-CS-Fixer
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Fix CS
         uses: docker://oskarstark/php-cs-fixer-ga
+        with:
+            args: --diff --dry-run
 
   build:
 
     strategy:
       matrix:
         container: [ "php81", "php82", "php83" ]
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     container: pugx/poser:${{ matrix.container }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Validate composer.json
         run: composer validate
 
       - name: Cache Composer packages
         id: composer-cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: vendor
           key: ${{ runner.os }}-php-${{ matrix.container }}-${{ hashFiles('**/composer.lock') }}

CONTRIBUTING.md

@@ -74,4 +74,13 @@ $ docker buildx build \
   .
 ```
 
+## Build a new PHP image on Linux
+
+* create a new PHP conf, e.g. `.docker/base/php84/Dockerfile` and `.docker/development/php84/Dockerfile `
+* `docker build -t poser-php84 --pull=false .docker/base/php84`
+* `docker login`
+* `docker tag poser-php84 pugx/poser:php84`
+* `docker push pugx/poser:php84`
+
+
 ## ENJOY

composer.json

@@ -28,7 +28,7 @@
     "repositories": [
         {
             "type": "vcs",
-            "url": "https://github.com/JellyBellyDev/phpspec-data-provider-extension"
+            "url": "https://github.com/madisoft/phpspec-data-provider-extension"
         }
     ],
     "require": {
@@ -41,10 +41,10 @@
     },
     "require-dev": {
         "behat/behat": "^3.13",
-        "phpspec/phpspec": "^7.4",
         "friends-of-phpspec/phpspec-code-coverage": "^6.3",
         "friendsofphp/php-cs-fixer": "^3.41",
-        "moave/phpspec-data-provider-extension": "dev-feat/add-compatibility-to-php80",
+        "moave/phpspec-data-provider-extension": "dev-master",
+        "phpspec/phpspec": "^7.4 || ^8.0",
         "vimeo/psalm": "^4.30"
     },
     "config": {

docker-compose.yml

@@ -1,4 +1,3 @@
-version: '3.7'
 services:
 
   php81:
@@ -24,3 +23,11 @@ services:
     stdin_open: true
     volumes:
       - .:/application:cached
+
+  php84:
+    build:
+      context: .docker/development/php84
+    working_dir: /application
+    stdin_open: true
+    volumes:
+      - .:/application:cached

src/Render/LocalSvgRenderer.php

@@ -29,7 +29,7 @@ abstract class LocalSvgRenderer implements RenderInterface
     private TextSizeCalculatorInterface $textSizeCalculator;
     private string $templatesDirectory;
 
-    public function __construct(TextSizeCalculatorInterface $textSizeCalculator = null, string $templatesDirectory = null)
+    public function __construct(?TextSizeCalculatorInterface $textSizeCalculator = null, ?string $templatesDirectory = null)
     {
         $this->textSizeCalculator = $textSizeCalculator ?? new GDTextSizeCalculator();
         $this->templatesDirectory = $templatesDirectory ?? (__DIR__ . '/../Resources/templates');

src/Render/SvgForTheBadgeRenderer.php

@@ -26,9 +26,9 @@ class SvgForTheBadgeRenderer extends LocalSvgRenderer
     private \EasySVG $easy;
 
     public function __construct(
-        \EasySVG $easySVG = null,
-        TextSizeCalculatorInterface $textSizeCalculator = null,
-        string $templatesDirectory = null
+        ?\EasySVG $easySVG = null,
+        ?TextSizeCalculatorInterface $textSizeCalculator = null,
+        ?string $templatesDirectory = null
     ) {
         parent::__construct($textSizeCalculator, $templatesDirectory);
 

src/UI/Command.php

@@ -29,7 +29,7 @@ class Command extends BaseCommand
 
     protected string $header;
 
-    public function __construct(string $name = null)
+    public function __construct(?string $name = null)
     {
         parent::__construct($name);
 

src/ValueObject/InputRequest.php

@@ -53,7 +53,7 @@ public static function createFromInput(InputInterface $input): self
         }
 
         if (!\is_string($format)) {
-            $format = BADGE::DEFAULT_FORMAT;
+            $format = Badge::DEFAULT_FORMAT;
         }
 
         return new self($subject, $status, $color, $style, $format);