Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failing service tests #1591

Closed
chris48s opened this issue Mar 20, 2018 · 4 comments
Closed

Update failing service tests #1591

chris48s opened this issue Mar 20, 2018 · 4 comments
Labels
bug Bugs in badges and the frontend

Comments

@chris48s
Copy link
Member

I did a full run of the service test suite as part of reviewing #1563 and there are a few failures we should probably look into. I've not properly investigated any of them, but some probably require updates:

     dotnet-status
       get nuget package status
         
	[ GET http://localhost:1111/dotnetstatus/gh/jaredcnance/dotnet-status/API.json ]:
     ValidationError: child "value" fails because ["value" must be one of [up to date, out of date, processing]]
     dotnet-status
       get nuget package status
         
	[ GET http://localhost:1111/dotnetstatus/gh/jaredcnance/dotnet-status/invalid-project.json ]:

      AssertionError: expected { Object (name, value) } to deeply equal { Object (name, value) }
      + expected - actual

       {
         "name": "dependencies"
      -  "value": "inconclusive"
      +  "value": "project not found"
       }
     Github
       Public domain license
         
	[ GET http://localhost:1111/github/license/badges/shields.json?style=_shields_test ]:

      AssertionError: expected { Object (colorB, name, ...) } to deeply equal { Object (name, value, ...) }
      + expected - actual

       {
      -  "colorB": "#9f9f9f"
      +  "colorB": "#7cd958"
         "name": "license"
      -  "value": "unknown"
      +  "value": "CC0-1.0"
       }
      MicroBadger
       image size without a specified tag
         
	[ GET http://localhost:1111/microbadger/image-size/jumanjiman/puppet.json ]:
     ValidationError: child "value" fails because ["value" with value "unknown" fails to match the required pattern: /^[0-9]*[.]?[0-9]+\s(B|kB|MB|GB|TB|PB|EB|ZB|YB)$/]
      MicroBadger
       image size without a specified tag and no download size data returned
         
	[ GET http://localhost:1111/microbadger/image-size/_/centos.json ]:

      AssertionError: expected { name: 'image size', value: '73 MB' } to deeply equal { Object (name, value) }
      + expected - actual

       {
         "name": "image size"
      -  "value": "73 MB"
      +  "value": "unknown"
       }
@PyvesB
Copy link
Member

PyvesB commented Mar 21, 2018

Hey @chris48s !

Regarding dotnet-status, I had noticed a while back and opened this issue in the author's repository. I was planning to let at least a month go by, and if he service is still down at that point, I would open a deprecation pull request for our badges. Does this make sense?

For MicroBadger, I had fixed the tests in #1536, but they seem to have broken once again. The returned data seems to regularly change and that makes the tests very unstable. I'll have another look at them sometime in the week-end. 😉

@paulmelnikow paulmelnikow added the bug Bugs in badges and the frontend label Mar 21, 2018
@chris48s
Copy link
Member Author

Good work. Looks like you're already on the 💼

@chris48s
Copy link
Member Author

chris48s commented Apr 2, 2018

@PyvesB
Copy link
Member

PyvesB commented May 5, 2018

Some of the MicroBadger tests have started failing once again. I've opened this issue to flag the problems with their service. Hopefully we'll be able to get reliable API responses sometime soon. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend
Projects
None yet
Development

No branches or pull requests

3 participants