Merge pull request #54 from DesmondSanctity/event-badging-submit-api

Event badging submit api

Author: adeyinkaoresanya

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,18 +1,19 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-title: 'Please provide a concise and informative title that summarizes the issue:
-  e.g. [BUG]<X> not working for <Y>'
+title:
+  "Please provide a concise and informative title that summarizes the issue:
+  e.g. [BUG]<X> not working for <Y>"
 labels: bug
-assignees: ''
-
+assignees: ""
 ---
 
 **Describe the bug**
 _A clear and concise description of what the bug is. Be specific and clear about what you were trying to do when the bug occurred._
 
 **Steps To Reproduce**
 _List the exact steps someone can take to reproduce the issue._
+
 1. Go to '...'
 2. Click on '....'
 3. Scroll down to '....'
@@ -26,16 +27,18 @@ _If applicable, add screenshots/screen recordings to help explain your problem._
 
 **Desktop specifications**
 _Please complete the following information if applicable):_
- - OS: [e.g. iOS]
- - Browser [e.g. chrome, safari]
- - Version [e.g. 22]
+
+- OS: [e.g. iOS]
+- Browser [e.g. chrome, safari]
+- Version [e.g. 22]
 
 **Smartphone specifications**
 _Please complete the following information if applicable):_
- - Device: [e.g. iPhone6]
- - OS: [e.g. iOS8.1]
- - Browser [e.g. stock browser, safari]
- - Version [e.g. 22]
+
+- Device: [e.g. iPhone6]
+- OS: [e.g. iOS8.1]
+- Browser [e.g. stock browser, safari]
+- Version [e.g. 22]
 
 **Additional context**
 • Provide any additional information that might help understand the issue. This could include links to relevant code snippets, configuration files, or other resources.

.github/ISSUE_TEMPLATE/doc-feedback.md

@@ -1,11 +1,11 @@
 ---
 name: Doc feedback
 about: Help us improve the docs
-title: 'Briefly describe the improvement you are requesting e.g. [DOC]: Improve clarity
-  of X'
-labels: ''
-assignees: ''
-
+title:
+  "Briefly describe the improvement you are requesting e.g. [DOC]: Improve clarity
+  of X"
+labels: ""
+assignees: ""
 ---
 
 **Description**

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,11 +1,11 @@
 ---
 name: Feature request
 about: Suggest an idea for this project
-title: 'Please provide a concise and informative title that summarizes the issue:
-  e.g. [FEATURE]: [Describe the desired feature]'
+title:
+  "Please provide a concise and informative title that summarizes the issue:
+  e.g. [FEATURE]: [Describe the desired feature]"
 labels: enhancement
-assignees: ''
-
+assignees: ""
 ---
 
 **Is your feature request related to a problem? Please describe.**

.github/pull_request_template.md

@@ -2,20 +2,20 @@
 
 **Summary:**
 
-* Briefly describe the changes introduced in this PR.
-* Make a reference to the related issue you are resolving. 
+- Briefly describe the changes introduced in this PR.
+- Make a reference to the related issue you are resolving.
 
 **Changes:**
 
-* List the specific files modified and a short summary of the changes made.
-* Use bullet points for clarity.
+- List the specific files modified and a short summary of the changes made.
+- Use bullet points for clarity.
 
 **Testing:**
 
-* Describe the steps taken to test the changes.
-* Mention any automated tests added or modified.
+- Describe the steps taken to test the changes.
+- Mention any automated tests added or modified.
 
 **Additional Notes:**
 
-* Include any relevant information not covered above.
-* Ask questions or provide guidance to reviewers.
+- Include any relevant information not covered above.
+- Ask questions or provide guidance to reviewers.

providers/github/auth.js

@@ -194,21 +194,8 @@ const handleOAuthCallback = async (req, res) => {
   }
 };
 
-/**
- * Sets up the provided Express app routes for GitLab
- * @param {*} app Express application instance
- */
-const githubAuthCallback = (app) => {
-  if (process.env.NODE_ENV === "production") {
-    app.post("/api/callback/github", handleOAuthCallback);
-  } else if (process.env.NODE_ENV === "development") {
-    app.get("/api/callback/github", handleOAuthCallback);
-  }
-};
-
 module.exports = {
   githubAuth,
-  githubAuthCallback,
   handleOAuthCallback,
   githubApp,
 };

providers/gitlab/auth.js

@@ -65,7 +65,7 @@ const requestAccessToken = async (code) => {
  * @returns A json object with `user_info` and `errors`
  * */
 
-const handleOAuthCallback = async (req, res) => {
+const handleOAuthCallbackGitlab = async (req, res) => {
   const code = req.body.code ?? req.query.code;
 
   const { access_token: accessToken, errors: accessTokenErrors } =
@@ -152,19 +152,7 @@ const handleOAuthCallback = async (req, res) => {
   }
 };
 
-/**
- * Sets up the provided Express app routes for GitLab
- * @param {*} app Express application instance
- */
-const gitlabAuthCallback = (app) => {
-  if (process.env.NODE_ENV === "production") {
-    app.post("/api/callback/gitlab", handleOAuthCallback);
-  } else if (process.env.NODE_ENV === "development") {
-    app.get("/api/callback/gitlab", handleOAuthCallback);
-  }
-};
-
 module.exports = {
   gitlabAuth,
-  gitlabAuthCallback,
+  handleOAuthCallbackGitlab,
 };

routes/index.js

@@ -4,13 +4,9 @@ const eventBadging = require("../event_badging/index.js");
 const github_helpers = require("../providers/github/APICalls.js");
 const gitlab_helpers = require("../providers/gitlab/APICalls.js");
 const { getAllEvents } = require("../database/controllers/event.controller.js");
-const {
-  githubAuth,
-  githubAuthCallback,
-  githubApp,
-  gitlabAuth,
-  gitlabAuthCallback,
-} = require("../providers/index.js");
+const { githubAuth, githubApp, gitlabAuth } = require("../providers/index.js");
+const { handleOAuthCallback } = require("../providers/github/auth.js");
+const { handleOAuthCallbackGitlab } = require("../providers/gitlab/auth.js");
 
 /**
  * Redirects the user to the GitHub OAuth login page for authentication.
@@ -160,8 +156,9 @@ const setupRoutes = (app) => {
   app.get("/api/login", login);
 
   //callbacks
-  githubAuthCallback(app);
-  gitlabAuthCallback(app);
+  app.post("/api/callback/github", handleOAuthCallback);
+  app.post("/api/callback/gitlab", handleOAuthCallbackGitlab);
+
   app.get("/api/badgedRepos", badgedRepos);
   app.post("/api/repos-to-badge", reposToBadge);