Format VK_WHOLE_SIZE properly on texel buffers in pipeline state

baldurk · baldurk · commit 435956cf4d89 · 2025-05-26T15:00:00.000+01:00
diff --git a/qrenderdoc/Windows/PipelineState/VulkanPipelineStateViewer.cpp b/qrenderdoc/Windows/PipelineState/VulkanPipelineStateViewer.cpp
@@ -790,10 +790,13 @@ bool VulkanPipelineStateViewer::setViewDetails(RDTreeWidgetItem *node, const Des
 
   if(descriptor.byteOffset + dynamicOffset > 0 || descriptor.byteSize < buf->length)
   {
+    uint64_t effectiveSize = descriptor.byteSize;
+    if(descriptor.byteSize == UINT64_MAX)
+      effectiveSize = buf->length - (descriptor.byteOffset + dynamicOffset);
     text +=
         tr("The view covers bytes %1-%2.\nThe buffer is %3 bytes in length.\n")
             .arg(Formatter::HumanFormat(descriptor.byteOffset + dynamicOffset, Formatter::OffsetSize))
-            .arg(Formatter::HumanFormat(descriptor.byteOffset + dynamicOffset + descriptor.byteSize,
+            .arg(Formatter::HumanFormat(descriptor.byteOffset + dynamicOffset + effectiveSize,
                                         Formatter::OffsetSize))
             .arg(Formatter::HumanFormat(buf->length, Formatter::OffsetSize));
   }

Original file line number	Diff line number	Diff line change
`@@ -790,10 +790,13 @@ bool VulkanPipelineStateViewer::setViewDetails(RDTreeWidgetItem *node, const Des`
`790`	`790`
`791`	`791`	`if(descriptor.byteOffset + dynamicOffset > 0 \|\| descriptor.byteSize < buf->length)`
`792`	`792`	`{`
	`793`	`+ uint64_t effectiveSize = descriptor.byteSize;`
	`794`	`+ if(descriptor.byteSize == UINT64_MAX)`
	`795`	`+ effectiveSize = buf->length - (descriptor.byteOffset + dynamicOffset);`
`793`	`796`	`text +=`
`794`	`797`	`tr("The view covers bytes %1-%2.\nThe buffer is %3 bytes in length.\n")`
`795`	`798`	`.arg(Formatter::HumanFormat(descriptor.byteOffset + dynamicOffset, Formatter::OffsetSize))`
`796`		`- .arg(Formatter::HumanFormat(descriptor.byteOffset + dynamicOffset + descriptor.byteSize,`
	`799`	`+ .arg(Formatter::HumanFormat(descriptor.byteOffset + dynamicOffset + effectiveSize,`
`797`	`800`	`Formatter::OffsetSize))`
`798`	`801`	`.arg(Formatter::HumanFormat(buf->length, Formatter::OffsetSize));`
`799`	`802`	`}`