Skip to content

Commit d4c1919

Browse files
committed
Fix assert check on format number of components for AtomicBinOp on UAV
Tweak error message about AtomicBinOp storing to out of bounds or unbound resource
1 parent f79b95c commit d4c1919

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

renderdoc/driver/shaders/dxil/dxil_debug.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3333,7 +3333,7 @@ bool ThreadState::ExecuteInstruction(DebugAPIWrapper *apiWrapper,
33333333
RDCASSERTNOTEQUAL(stride, 1);
33343334

33353335
RDCASSERTEQUAL(result.columns, 1);
3336-
RDCASSERTEQUAL(fmt.numComps, result.columns);
3336+
RDCASSERTEQUAL(fmt.numComps * fmt.byteWidth, GetElementByteSize(result.type));
33373337
RDCASSERTNOTEQUAL(stride, 0);
33383338
RDCASSERTNOTEQUAL(fmt.compType, CompType::Typeless);
33393339

@@ -3515,7 +3515,8 @@ bool ThreadState::ExecuteInstruction(DebugAPIWrapper *apiWrapper,
35153515
// NULL resource or out of bounds
35163516
if((!texData && elemIdx >= numElems) || (texData && dataOffset >= dataSize))
35173517
{
3518-
RDCERR("Ignoring store to unbound resource %s", GetArgumentName(1).c_str());
3518+
RDCERR("Ignoring store to unbound resource or out of bounds store %s",
3519+
GetArgumentName(1).c_str());
35193520
}
35203521
else
35213522
{

0 commit comments

Comments
 (0)