Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies in network configuration state apply #2251

Open
cywang117 opened this issue Mar 15, 2024 · 0 comments · Fixed by #2400
Open

Inconsistencies in network configuration state apply #2251

cywang117 opened this issue Mar 15, 2024 · 0 comments · Fixed by #2400

Comments

@cywang117
Copy link
Contributor

Problem

On a release update where the only thing that changes is the network configuration, a network won't be removed if it has a custom configuration and the target config of that network is the default config

Reproduction

With the following two releases:

version: '2.4'

services:
  one:
    image: alpine
    command: sh -c "echo one-new && sleep infinity"
    stop_signal: SIGKILL
    networks:
      - test
  two:
    image: alpine
    command: sh -c "echo two-new && sleep infinity"
    stop_signal: SIGKILL
    networks:
      - test

networks:
  test:
    ipam:
      driver: default
      config:
        - subnet: 172.28.0.0/16
          gateway: 172.28.5.254

version: '2.4'

services:
  one:
    image: alpine
    command: sh -c "echo one-new && sleep infinity"
    stop_signal: SIGKILL
    networks:
      - test
  two:
    image: alpine
    command: sh -c "echo two-new && sleep infinity"
    stop_signal: SIGKILL
    networks:
      - test

networks:
  test:

Pin back and forth between them, and observe that once a network has been configured with the custom ipam configs, it won't ever be recreated with the default configs even if pinning to the latter release.
cywang117 added a commit that referenced this issue Jan 29, 2025
@cywang117
Add Docker network label if custom ipam config
ad0b4a3 
In a target release where the only change is the addition or removal
of a custom ipam config, the Supervisor does not recreate the network
due to ignoring ipam config differences when comparing current and target
network (in network.isEqualConfig). This commit implements the addition of
a network label if the target compose object includes a network with custom
ipam. With the label, the Supervisor will detect a difference between a
network with a custom ipam and a network without, without needing to compare
the ipam configs themselves.

Closes: #2251
Change-type: patch
Signed-off-by: Christina Ying Wang <[email protected]>
@cywang117 cywang117 mentioned this issue Jan 29, 2025
Merged
cywang117 added a commit that referenced this issue Jan 29, 2025
@cywang117
Add Docker network label if custom ipam config
102ab21 
In a target release where the only change is the addition or removal
of a custom ipam config, the Supervisor does not recreate the network
due to ignoring ipam config differences when comparing current and target
network (in network.isEqualConfig). This commit implements the addition of
a network label if the target compose object includes a network with custom
ipam. With the label, the Supervisor will detect a difference between a
network with a custom ipam and a network without, without needing to compare
the ipam configs themselves.

This is a major change, as devices running networks with custom ipam configs
will have their networks recreated to add the network label.

Closes: #2251
Change-type: major
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117 added a commit that referenced this issue Feb 6, 2025
@cywang117
Add Docker network label if custom ipam config
0750d4a 
In a target release where the only change is the addition or removal
of a custom ipam config, the Supervisor does not recreate the network
due to ignoring ipam config differences when comparing current and target
network (in network.isEqualConfig). This commit implements the addition of
a network label if the target compose object includes a network with custom
ipam. With the label, the Supervisor will detect a difference between a
network with a custom ipam and a network without, without needing to compare
the ipam configs themselves.

This is a major change, as devices running networks with custom ipam configs
will have their networks recreated to add the network label.

Closes: #2251
Change-type: major
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117 added a commit that referenced this issue Feb 6, 2025
@cywang117
Add Docker network label if custom ipam config
9afb7ef 
In a target release where the only change is the addition or removal
of a custom ipam config, the Supervisor does not recreate the network
due to ignoring ipam config differences when comparing current and target
network (in network.isEqualConfig). This commit implements the addition of
a network label if the target compose object includes a network with custom
ipam. With the label, the Supervisor will detect a difference between a
network with a custom ipam and a network without, without needing to compare
the ipam configs themselves.

This is a major change, as devices running networks with custom ipam configs
will have their networks recreated to add the network label.

Closes: #2251
Change-type: major
See: https://balena.fibery.io/Work/Project/Supervisor-maintenance-work-(Dec-2024)-948
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117 added a commit that referenced this issue Feb 20, 2025
@cywang117
Add Docker network label if custom ipam config
7ebddda 
In a target release where the only change is the addition or removal
of a custom ipam config, the Supervisor does not recreate the network
due to ignoring ipam config differences when comparing current and target
network (in network.isEqualConfig). This commit implements the addition of
a network label if the target compose object includes a network with custom
ipam. With the label, the Supervisor will detect a difference between a
network with a custom ipam and a network without, without needing to compare
the ipam configs themselves.

This is a major change, as devices running networks with custom ipam configs
will have their networks recreated to add the network label.

Closes: #2251
Change-type: major
See: https://balena.fibery.io/Work/Project/Supervisor-maintenance-work-(Dec-2024)-948
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117 added a commit that referenced this issue Feb 20, 2025
@cywang117
Add Docker network label if custom ipam config
d15158a 
In a target release where the only change is the addition or removal
of a custom ipam config, the Supervisor does not recreate the network
due to ignoring ipam config differences when comparing current and target
network (in network.isEqualConfig). This commit implements the addition of
a network label if the target compose object includes a network with custom
ipam. With the label, the Supervisor will detect a difference between a
network with a custom ipam and a network without, without needing to compare
the ipam configs themselves.

This is a major change, as devices running networks with custom ipam configs
will have their networks recreated to add the network label.

Closes: #2251
Change-type: major
See: https://balena.fibery.io/Work/Project/Fix-Supervisor-not-recreating-network-when-passed-custom-ipam-config-1127
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117 added a commit that referenced this issue Mar 12, 2025
@cywang117
Add Docker network label if custom ipam config
3dbb25b 
In a target release where the only change is the addition or removal
of a custom ipam config, the Supervisor does not recreate the network
due to ignoring ipam config differences when comparing current and target
network (in network.isEqualConfig). This commit implements the addition of
a network label if the target compose object includes a network with custom
ipam. With the label, the Supervisor will detect a difference between a
network with a custom ipam and a network without, without needing to compare
the ipam configs themselves.

This is a major change, as devices running networks with custom ipam configs
will have their networks recreated to add the network label.

Closes: #2251
Change-type: major
See: https://balena.fibery.io/Work/Project/Fix-Supervisor-not-recreating-network-when-passed-custom-ipam-config-1127
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117 added a commit that referenced this issue Mar 24, 2025
@cywang117
Add Docker network label if custom ipam config
b596c77 
In a target release where the only change is the addition or removal
of a custom ipam config, the Supervisor does not recreate the network
due to ignoring ipam config differences when comparing current and target
network (in network.isEqualConfig). This commit implements the addition of
a network label if the target compose object includes a network with custom
ipam. With the label, the Supervisor will detect a difference between a
network with a custom ipam and a network without, without needing to compare
the ipam configs themselves.

This is a major change, as devices running networks with custom ipam configs
will have their networks recreated to add the network label.

Closes: #2251
Change-type: major
See: https://balena.fibery.io/Work/Project/Fix-Supervisor-not-recreating-network-when-passed-custom-ipam-config-1127
Signed-off-by: Christina Ying Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Docker network label if custom ipam config balena-os/balena-supervisor
1 participant
@cywang117