Merge pull request #190 from Saibamen/optimize_CheckNumericOnly

barnhill · web-flow · commit aed199dfab55 · 2024-02-03T23:36:56.000-06:00
Optimize `CheckNumericOnly`
diff --git a/BarcodeStandard/BarcodeCommon.cs b/BarcodeStandard/BarcodeCommon.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 
 namespace BarcodeStandard
 {
@@ -17,15 +16,14 @@ protected void Error(string errorMessage)
 
         internal static bool CheckNumericOnly(string data)
         {
-            char c;
-            for (int i = 0; i < data.Length; i++)
+            foreach (var c in data)
             {
-                c = data[i];
                 if (c < '0' && c > '9') return false;
             }
+
             return true;
         }
-        
+
         internal static int GetAlignmentShiftAdjustment(Barcode barcode)
         {
             switch (barcode.Alignment)

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
`3`		`-using System.Linq;`
`4`	`3`
`5`	`4`	`namespace BarcodeStandard`
`6`	`5`	`{`
`@@ -17,15 +16,14 @@ protected void Error(string errorMessage)`
`17`	`16`
`18`	`17`	`internal static bool CheckNumericOnly(string data)`
`19`	`18`	`{`
`20`		`- char c;`
`21`		`- for (int i = 0; i < data.Length; i++)`
	`19`	`+ foreach (var c in data)`
`22`	`20`	`{`
`23`		`- c = data[i];`
`24`	`21`	`if (c < '0' && c > '9') return false;`
`25`	`22`	`}`
	`23`	`+`
`26`	`24`	`return true;`
`27`	`25`	`}`
`28`		`-`
	`26`	`+`
`29`	`27`	`internal static int GetAlignmentShiftAdjustment(Barcode barcode)`
`30`	`28`	`{`
`31`	`29`	`switch (barcode.Alignment)`