Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(De)?Serialization should report problem in a clean manner if DU does not have unique Event Type names #3

Open
bartelink opened this issue Aug 28, 2014 · 0 comments

Comments

@bartelink
Copy link
Owner

In EncodedEvent.serializeUnionByCaseItemType and its inverse there is a reliance on a Seq.exactlyOne.

This should be replaced with a cached DU-level consistency verification with a clear message using a technique such as that in

let converters<'a> =
let valueConverters =
getValues typeof<'a>.Assembly
|> Seq.map valueConverter
|> Seq.toList
[ unionConverter; optionConverter]
@ valueConverters
allowing the actual lookup to just be on a find-first basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant