Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get this to work like the old blueprint - southern hemisphere? #217

Open
3 tasks done
kineticscreen opened this issue Jun 15, 2024 · 6 comments
Open
3 tasks done

Comments

@kineticscreen
Copy link

kineticscreen commented Jun 15, 2024

What version of Adaptive Cover are you using?

1.3.1

What version of Home Assistant are you using?

2024.6.3

Checklist

  • I have filled out the issue template to the best of my ability.
  • This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
  • This issue is not a duplicate issue of currently previous issues..

Describe the issue

I cannot get this to work correctly, and I'm just trying to replicate the old blueprint version I've been using fine.
Once the sun rises the blind moves to the 'maximum position' (badly named and explained btw, very difficult to understand) and just stays there.

I'm assuming this is set up correctly, again just replicating what has been working perfectly with the blueprint version:
I just want the blind to be open, until the sun starts to track in, at which point it should progressively close up until it is only 30% open, and then stop there.

image

With this configuration, it is AM here and the blind is already down at 30%. Is it possible that there is an error for the South Hemisphere? Though the sensors indicate the sun is 'clear'.

image Screenshot 2024-06-16 at 9 48 03 AM

Reproduction steps

Whether I have 100% in Default, and 30% in Max or swap them around so that Default is 30% and Max is 100%, the blind stays at 30% when no sun is detected.

Diagnostics dump

"data": {
"title": "Adaptive Cover Configuration",
"type": "config_entry",
"identifier": "42d190d1a85de239d6dbbc18ee7b363e",
"config_data": {
"__type": "<class 'mappingproxy'>",
"repr": "mappingproxy({'name': 'Bluray Blinds', 'sensor_type': 'cover_blind'})"
},
"config_options": {
"__type": "<class 'mappingproxy'>",
"repr": "mappingproxy({'mode': 'basic', 'set_azimuth': 275.0, 'window_height': 2.1, 'distance_shaded_area': 0.2, 'default_percentage': 100.0, 'max_position': 30.0, 'fov_left': 90.0, 'fov_right': 85.0, 'group': ['cover.moes_smartblind'], 'inverse_state': False, 'sunset_position': 100.0, 'sunset_offset': 0.0, 'sunrise_offset': 0.0, 'length_awning': None, 'angle': None, 'slat_distance': None, 'slat_depth': None, 'tilt_mode': None, 'temp_entity': None, 'presence_entity': None, 'weather_entity': None, 'temp_low': None, 'temp_high': None, 'outside_temp': None, 'climate_mode': False, 'weather_state': None, 'delta_position': 10.0, 'delta_time': 2.0, 'start_time': '00:00:00', 'start_entity': None, 'manual_override_duration': {'minutes': 15}, 'manual_override_reset': False, 'manual_threshold': None, 'manual_ignore_intermediate': False, 'blind_spot_right': None, 'blind_spot_left': None, 'blind_spot_elevation': None, 'blind_spot': False, 'min_elevation': 18, 'max_elevation': None, 'transparent_blind': False, 'interp': False})"
}
}
}

@kineticscreen kineticscreen changed the title Cannot get this to work like the old blueprint - south hermisphere? Cannot get this to work like the old blueprint - southern hemisphere? Jun 15, 2024
@basbruss
Copy link
Owner

@kineticscreen A maximum allowed position means that the position of the cover can never be higher than that position, so in your case 30%. Since it's AM for you and the sun is only to be estimated to be in front of your window within 3 hours I guess it's before sunrise, so the default value is actually determined by the sunset default (between sunset and sunrise), which is also 100%, so is limited to the maximum open position of 30%.

@kineticscreen
Copy link
Author

No it's after sunrise, but that does make some sense. So if the max position is actually not like the old template, and is a hard limit to how open the cover can be, then what's the default position?
Does that mean that there isn't the equivalent of the old limit, which limited how far closed the cover would go? That's really all I want to do.

@basbruss
Copy link
Owner

basbruss commented Jun 16, 2024

Sorry, the correct explanation is that if you set the default to 30% and the sun is not in front of the window the position should be equal to the default, in your case 30% with a maximum of 100%.

This integration is not really similar in function to the blueprint and differs heavily in available features since you can do not everything when limited to jinja.

Setting a minimum position basically defeats the purpose of the integration to find the most optimal position to block out direct sunlight while allowing natural light to come into the room. Otherwise, if you only need the simple position with a closed limit the blueprint should be fine and the integration is probably not needed.

But in any case you can create a simple automation in HA to override the position and turn off the adaptive function when needed

@kineticscreen
Copy link
Author

Sorry, the correct explanation is that if you set the default to 30% and the sun is not in front of the window the position should be equal to the default, in your case 30% with a maximum of 100%.

I still don't understand what the use of the maximum is, but regardless I strongly suggest you completely rewrite the descriptions in the controls. They assume people know what the terms mean, and don't actually explain them.

"Default cover position as a percentage" assumes people know what "default cover position" means and what the percentage refers to.
"Maximum adjustable cover position as a percentage" similarly assumes people know what the "maximum adjustable cover position" refers to, and again what the percentage means.
And using terms like "maximum" alongside percentages is very confusing because is the maximum 100% or 0%?

I would help rewrite them for you, but I still don't understand from your explanation the point of the Default Vs Maximum positions.

It might help if you have at least one or two sample setups in the documentation.

@basbruss
Copy link
Owner

basbruss commented Jun 16, 2024

Ah you are referring to the (short) descriptions of the options flow. All variables are also documented on this GitHub page.

"Default cover position as a percentage" assumes people know what "default cover position" means and what the percentage refers to.

This is deeply covered in the algorithm diagram on this page.

"Maximum adjustable cover position as a percentage" similarly assumes people know what the "maximum adjustable cover position" refers to, and again what the percentage means.

This is because certain types of covers should not opened fully because that will put them under too much strain, like for example Roman shades #39

So if you set a default that is higher than the maximum opening position the default gets overridden like any other state that is larger than the maximum position.

It might help if you have at least one or two sample setups in the documentation.

Any help with documentation in the form of a PR is very welcome, as I don't always have the focus or time to write extensive documentation while adding new functionality. I'm also aware that concepts which seem logical or natural to me can be hard to understand for others. Therefore, a second or third set of eyes is always beneficial. 😄

@kineticscreen
Copy link
Author

kineticscreen commented Jun 26, 2024

Re minimum position, there is a current discussion #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants