Skip to content

[Data] world_iea_timss #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

[Data] world_iea_timss #1100

wants to merge 37 commits into from

Conversation

laribritto
Copy link
Collaborator

@laribritto laribritto commented May 22, 2025 •
edited by tricktx
Loading

Descrição do PR:

  • Subida dos dados da Timss para produção.

Teste e Validações:

  • Relate os testes e validações relacionado aos dados/script:
    • Testado localmente
    • Testado na Cloud

Todos os testes passaram localmente, segue imagem...
image

@tricktx tricktx changed the title tabela timss [Data] world_iae_timss May 22, 2025
@tricktx tricktx requested a review from a team May 22, 2025 13:18
@tricktx tricktx added the table-approve Triggers Table Approve on PR merge label May 22, 2025
aspeddro
aspeddro requested changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@aspeddro aspeddro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei alguns comentários sobre a macro set_datalake_project.

Aqui o guia de como usar

Em algumas tabela está assim world_iae_timss.<TABLE_ID> e outra world_iae_timss_staging.<TABLE_ID>

@laribritto laribritto requested a review from aspeddro May 22, 2025 20:05
@aspeddro aspeddro added the test-dev-model Run DBT tests in the modified models using basedosdados-dev Bigquery Project label May 23, 2025
aspeddro
aspeddro requested changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@aspeddro aspeddro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Os testes estão falhando com a seguinte mensagem 'test_custom_dictionaries' is undefined. This can happen when calling a macro that does not exist. Check for typos and/or install package dependencies with "dbt deps"

aspeddro
aspeddro reviewed Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@aspeddro aspeddro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só tem uma questão pendente.

@laribritto laribritto requested review from aspeddro and tricktx June 25, 2025 01:01
@aspeddro aspeddro marked this pull request as draft June 27, 2025 14:07
@aspeddro aspeddro changed the title [Data] world_iae_timss [Data] world_iea_timss Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspeddro aspeddro Awaiting requested review from aspeddro

@tricktx tricktx Awaiting requested review from tricktx

Requested changes must be addressed to merge this pull request.

Assignees

@laribritto laribritto

Labels
table-approve Triggers Table Approve on PR merge test-dev-model Run DBT tests in the modified models using basedosdados-dev Bigquery Project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laribritto @aspeddro @tricktx