Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement “Merchant Fee Deduction” Feature (Better Name Needed) #999

Open
yondifon opened this issue Sep 21, 2024 · 2 comments · May be fixed by #1003
Open

Implement “Merchant Fee Deduction” Feature (Better Name Needed) #999

yondifon opened this issue Sep 21, 2024 · 2 comments · May be fixed by #1003
Assignees
@rez1dent3
Labels
backlog enhancement New feature or request good issue Good for newcomers

Comments

@yondifon
Copy link

Is your feature request related to a problem? Please describe.
Yes, the current implementation of the Taxable adds fee to the product price which is paid by the user.

However, there are situations I want fee to be deducted from the merchant’s payout instead of being added to the user’s purchase amount. This would enable users to pay only the listed product price, enhancing their purchasing experience by providing transparent and all-inclusive pricing.

Describe the solution you'd like
I propose a new interface (can't really come up with a good name) or extension of current interface that reverses the current fee handling mechanism.

Describe alternatives you've considered

  • Withdrawing platform fee from the merchant after purchase.
  • Also extending package but as this is an open source, thought ifapproved my solution with your help will be available to everyone.

Additional context
Add any other context or screenshots about the feature request here.
Proposed Behavior (New Interface):
Wallet A Pays: $100
Wallet B Receives: $95 ($100 - $5 fee)
Fee: $5 fee
@yondifon yondifon added the enhancement New feature or request label Sep 21, 2024
@rez1dent3 rez1dent3 added the good issue Good for newcomers label Sep 21, 2024
@rez1dent3
Copy link
Member

@yondifon Hello. Thanks for the feedback and the feature suggestion.

I've wanted to rework the commissions and taxes functionality for a long time. It was done poorly, but I never got around to it, because it's the least popular functionality.

Seeing that someone actually uses this functionality, I'll try to get back to reworking the functionality in the near future.

I can't promise a feature within wallet ^11.0, because I might break backward compatibility, but I'll try.

@yondifon
Copy link
Author

Thank you @rez1dent3 (and the other contributors)

I can send in a PR if you want but maybe some documentation on how it will work from your end will be useful.

@rez1dent3 rez1dent3 linked a pull request Oct 10, 2024 that will close this issue
[11.4] Feature New TaxInterface #1003
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rez1dent3 rez1dent3

Labels
backlog enhancement New feature or request good issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[11.4] Feature New TaxInterface bavix/laravel-wallet
2 participants
@rez1dent3 @yondifon