Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like rules-proto-grpc/rules_proto_grpc no longer supports java #90

Closed
wcurrie opened this issue Dec 25, 2023 · 3 comments
Closed

Comments

@wcurrie
Copy link

wcurrie commented Dec 25, 2023

As of this commit rules-proto-grpc/rules_proto_grpc@8b8dc50, it looks like there's no support for java in rules-proto-grpc. Should the table here be updated?

image

There's no java listed here either

image

Maybe the rule from grpc-java should be mentioned instead?

From the discussion here, maybe the desired state isn't known yet:

Do you have a recommendation of which one?

@cgrindel
Copy link
Member

Based upon this issue, it looks like they intend to support it. Since this seems related to the migration to bzlmod and java support is available on their legacy branch, I recommend that we not update the table.

@wcurrie
Copy link
Author

wcurrie commented Dec 28, 2023

Ah, so maybe the plan/thinking is java support back to the master branch after they work out how to add bzlmod support to grpc-java. That's probably what is explained in rules-proto-grpc/rules_proto_grpc#269

Step 1 on this process will be a minimum viable module that maybe just supports a single language.

I'd not understood that sorry. It's currently a bit confusing since the generated rules-proto-grpc docs linked from the legacy branch (and served from googling) don't mention java right now

Full documentation for the current and previous versions can be found here

Thanks!

@wcurrie wcurrie closed this as completed Dec 28, 2023
@wcurrie
Copy link
Author

wcurrie commented Dec 28, 2023

Noting for anybody else. On the docs site, there's a version toggle at the bottom. Switch off latest to see the docs about java

image

https://rules-proto-grpc.com/en/4.5.0/

And there's a note in the readme too

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants